Skip to content

Send a UserAgent header to the symbolication server again#5103

Merged
mstange merged 1 commit into
firefox-devtools:mainfrom
mstange:add-back-ua
Aug 29, 2024
Merged

Send a UserAgent header to the symbolication server again#5103
mstange merged 1 commit into
firefox-devtools:mainfrom
mstange:add-back-ua

Conversation

@mstange

@mstange mstange commented Aug 29, 2024

Copy link
Copy Markdown
Contributor

This will make it easier to determine what's causing load on the servers.

…his request as coming from the Firefox Profiler.
@mstange mstange requested a review from julienw August 29, 2024 14:49
@mstange mstange self-assigned this Aug 29, 2024
@codecov

codecov Bot commented Aug 29, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.48%. Comparing base (6a8c668) to head (2f855af).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5103   +/-   ##
=======================================
  Coverage   88.48%   88.48%           
=======================================
  Files         304      304           
  Lines       27523    27523           
  Branches     7444     7444           
=======================================
  Hits        24355    24355           
  Misses       2943     2943           
  Partials      225      225           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@julienw julienw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@mstange mstange merged commit ac4ae1f into firefox-devtools:main Aug 29, 2024
@canova canova mentioned this pull request Sep 5, 2024
canova added a commit that referenced this pull request Sep 5, 2024
[Tatsuyuki Ish] Fix type error in getPagesMap (#5063)
[Nazım Can Altınova] [Tab selector 1] Add a redux state for the tab
filter (#5072)
[Markus Stange] Remove a test for the inverted stack chart. (#5075)
[Markus Stange] Add an inverted tree test for getSamplesSelectedStates
and getTreeOrderComparator (#5076)
[Nazım Can Altınova] [Tab selector 2] Extract the page data in the full
view (#5073)
[Nazım Can Altınova] Do not crash on timeline hover/selection when a
profile doesn't have any samples or markers (#5086)
[Nazım Can Altınova] [Tab selector 3] Generate page information for all
tabs (#5082)
[Nazım Can Altınova] [Tab selector 4] Add a getTabToThreadIndexesMap
selector to get relevant threads per tab (#5087)
[joshuaobrien] Use the word 'archive' instead of 'zip file' in copy
(#5081)
[Markus Stange] Send a UserAgent header to the symbolication server
again (#5103)
[Julien Wajsberg] Add some console utilities to retrieve the current
profile and save it to disk (#5105)
[Nazım Can Altınova]  Add `selectedMarker` to the console APIs (#5107)
And various dependency updates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants