Simplify getIsBottomBoxOpen selector.#4476
Merged
Merged
Conversation
Codecov ReportBase: 88.63% // Head: 88.63% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4476 +/- ##
==========================================
- Coverage 88.63% 88.63% -0.01%
==========================================
Files 284 284
Lines 25536 25535 -1
Branches 6865 6865
==========================================
- Hits 22634 22633 -1
Misses 2695 2695
Partials 207 207
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
julienw
approved these changes
Feb 17, 2023
julienw
left a comment
julienw
left a comment
Contributor
There was a problem hiding this comment.
fully agree, thanks for the simplification
mstange
force-pushed
the
getisbottomboxopen
branch
from
c6adcda to
26b60b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was no need to call
createSelector- nothing needs to be cached.