Skip to content

Simplify getIsBottomBoxOpen selector. #4476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mstange merged 1 commit into from
Feb 17, 2023
Merged

Simplify getIsBottomBoxOpen selector. #4476

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions src/selectors/url-state.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ import type {
ProfileSpecificUrlState,
FullProfileSpecificUrlState,
ActiveTabSpecificProfileUrlState,
IsOpenPerPanelState,
} from 'firefox-profiler/types';

import type { TabSlug } from '../app-logic/tabs-handling';
Expand Down Expand Up @@ -81,9 +80,6 @@ export const getSourceViewFile: Selector<string | null> = (state) =>
getProfileSpecificState(state).sourceView.file;
export const getSourceViewActivationGeneration: Selector<number> = (state) =>
getProfileSpecificState(state).sourceView.activationGeneration;
export const getisBottomBoxOpenPerPanel: Selector<IsOpenPerPanelState> = (
state
) => getProfileSpecificState(state).isBottomBoxOpenPerPanel;
export const getShowJsTracerSummary: Selector<boolean> = (state) =>
getFullProfileSpecificState(state).showJsTracerSummary;
export const getTimelineTrackOrganization: Selector<
Expand Down Expand Up @@ -216,12 +212,10 @@ export const getTransformStack: DangerousSelectorWithArguments<
);
};

export const getIsBottomBoxOpen: Selector<boolean> = createSelector(
getisBottomBoxOpenPerPanel,
getSelectedTab,
(isBottomBoxOpenPerPanel, selectedTabSlug) =>
isBottomBoxOpenPerPanel[selectedTabSlug]
);
export const getIsBottomBoxOpen: Selector<boolean> = (state) => {
const tab = getSelectedTab(state);
return getProfileSpecificState(state).isBottomBoxOpenPerPanel[tab];
};

/**
* The URL predictor is used to generate a link for an uploaded profile, to predict
Expand Down