Tweak the space before the stack implementation filter's label#4581
Merged
julienw merged 2 commits intoApr 21, 2023
Conversation
canova
approved these changes
Apr 21, 2023
Member
There was a problem hiding this comment.
It looks good to me, thanks! But I'm very bad at seeing these small differences for some reason. I couldn't see this on my previous review as well 😅 I think Markus is a lot better at this 😄
While I was testing it, I found another issue though. When I try to change the width and narrow down the Firefox window, the UI breaks at some point. See the screenshots below:
Edit: Filed #4585 for that.
Contributor
Author
|
Thanks, I commented there! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4580
Before:
After:
