Upgrade node to v18.16#4582
Conversation
The ICU changes come from nodejs/node#46646 in node v18.15.
julienw
force-pushed
the
upgrade-node-18.16
branch
from
ca99d7e to
dc09769
Compare
| { | ||
| "private": true, | ||
| "engines": { | ||
| "node": ">= 18.16 < 19" |
There was a problem hiding this comment.
Do we necessarily have to set an upper limit? I think our pre-install script currently checks the lower bound but doesn't do anything for the upper.
There was a problem hiding this comment.
I think it's common that there are issues with newer versions, that's why I prefer to control it further. This will be a reminder if some user update their node version without realizing that and then report a bug. Althought that reporting a bug can be useful too, as we may know about the problems earlier than when we try it ourselves?
Still I believe we can relax this later if this proves to be more a drawback than an advantage.
What do you think?
There was a problem hiding this comment.
Oh sorry I just saw this comment. I think it's good like this as well. We will definitely know when we try to upgrade the node version ourselves. We can also change it in the future if people complain about it, but I doubt it :)
2 participants
No description provided.