Skip to content

Upgrade node to v18.16 #4582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julienw merged 2 commits into from
Apr 20, 2023
Merged

Upgrade node to v18.16 #4582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0d6064
Upgrade node to v18.16 and update tests following the ICU change
julienw Apr 19, 2023
dc09769
Add the node engine version constraint in package.json as well
julienw Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ version: 2.1
executors:
node:
docker:
- image: cimg/node:18.14
- image: cimg/node:18.16
base:
docker:
- image: cimg/base:stable
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.14
18.16
2 changes: 1 addition & 1 deletion appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
clone_depth: 5
environment:
nodejs_version: "18.14"
nodejs_version: "18.16"
platform: x64 # flow needs 64b platforms

branches:
Expand Down
3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
{
"private": true,
"engines": {
"node": ">= 18.16 < 19"

@canova canova Apr 19, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we necessarily have to set an upper limit? I think our pre-install script currently checks the lower bound but doesn't do anything for the upper.

@julienw julienw Apr 19, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's common that there are issues with newer versions, that's why I prefer to control it further. This will be a reminder if some user update their node version without realizing that and then report a bug. Althought that reporting a bug can be useful too, as we may know about the problems earlier than when we try it ourselves?
Still I believe we can relax this later if this proves to be more a drawback than an advantage.
What do you think?

@canova canova Apr 20, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry I just saw this comment. I think it's good like this as well. We will definitely know when we try to upgrade the node version ourselves. We can also change it in the future if people complain about it, but I doubt it :)

},
"scripts": {
"build:clean": "rimraf dist && mkdirp dist",
"build:quiet": "yarn build:clean && cross-env NODE_ENV=development webpack",
Expand Down
10 changes: 4 additions & 6 deletions src/test/components/WindowTitle.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ describe('WindowTitle', () => {
);

expect(document.title).toBe(
'Firefox – 1/1/1970, 12:00:00\u202FAM UTC – Firefox Profiler'
'Firefox – 1/1/1970, 12:00:00 AM UTC – Firefox Profiler'
);
});

Expand All @@ -56,7 +56,7 @@ describe('WindowTitle', () => {
);

expect(document.title).toBe(
'Firefox – macOS 10.14 – 1/1/1970, 12:00:00\u202FAM UTC – Firefox Profiler'
'Firefox – macOS 10.14 – 1/1/1970, 12:00:00 AM UTC – Firefox Profiler'
);
});

Expand Down Expand Up @@ -100,9 +100,7 @@ describe('WindowTitle', () => {
</Provider>
);

expect(document.title).toBe(
'1/1/1970, 12:00:00\u202FAM UTC – Firefox Profiler'
);
expect(document.title).toBe('1/1/1970, 12:00:00 AM UTC – Firefox Profiler');
});

it('shows the correct title for uploaded recordings', () => {
Expand Down Expand Up @@ -169,7 +167,7 @@ describe('WindowTitle', () => {
);

expect(document.title).toBe(
'bar/profile1.json – Firefox – 1/1/1970, 12:00:00\u202FAM UTC – Firefox Profiler'
'bar/profile1.json – Firefox – 1/1/1970, 12:00:00 AM UTC – Firefox Profiler'
);
});
});
16 changes: 8 additions & 8 deletions src/test/components/__snapshots__/ListOfPublishedProfiles.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ exports[`ListOfPublishedProfiles limits the number of rendered profiles with the
<div
class="publishedProfilesDate"
>
2:00 PM
2:00 PM
</div>
<div
class="publishedProfilesInfo"
Expand Down Expand Up @@ -104,7 +104,7 @@ exports[`ListOfPublishedProfiles limits the number of rendered profiles with the
<div
class="publishedProfilesDate"
>
1:00 PM
1:00 PM
</div>
<div
class="publishedProfilesInfo"
Expand Down Expand Up @@ -304,7 +304,7 @@ exports[`ListOfPublishedProfiles renders action buttons when appropriate 1`] = `
<div
class="publishedProfilesDate"
>
2:00 PM
2:00 PM
</div>
<div
class="publishedProfilesInfo"
Expand Down Expand Up @@ -363,7 +363,7 @@ exports[`ListOfPublishedProfiles renders action buttons when appropriate 1`] = `
<div
class="publishedProfilesDate"
>
1:00 PM
1:00 PM
</div>
<div
class="publishedProfilesInfo"
Expand Down Expand Up @@ -420,7 +420,7 @@ exports[`ListOfPublishedProfiles renders action buttons when appropriate 1`] = `
<div
class="publishedProfilesDate"
>
Jul 3, 8:00 AM
Jul 3, 8:00 AM
</div>
<div
class="publishedProfilesInfo"
Expand Down Expand Up @@ -543,7 +543,7 @@ exports[`ListOfPublishedProfiles still displays the link to all recordings when
<div
class="publishedProfilesDate"
>
2:00 PM
2:00 PM
</div>
<div
class="publishedProfilesInfo"
Expand Down Expand Up @@ -586,7 +586,7 @@ exports[`ListOfPublishedProfiles still displays the link to all recordings when
<div
class="publishedProfilesDate"
>
Jul 3, 8:00 AM
Jul 3, 8:00 AM
</div>
<div
class="publishedProfilesInfo"
Expand Down Expand Up @@ -692,7 +692,7 @@ exports[`ListOfPublishedProfiles still displays the link to all recordings when
<div
class="publishedProfilesDate"
>
2:00 PM
2:00 PM
</div>
<div
class="publishedProfilesInfo"
Expand Down
6 changes: 3 additions & 3 deletions src/test/components/__snapshots__/UploadedRecordingsHome.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ exports[`UploadedRecordingsHome matches a snapshot when rendering published prof
<div
class="publishedProfilesDate"
>
2:00 PM
2:00 PM
</div>
<div
class="publishedProfilesInfo"
Expand Down Expand Up @@ -182,7 +182,7 @@ exports[`UploadedRecordingsHome matches a snapshot when rendering published prof
<div
class="publishedProfilesDate"
>
1:00 PM
1:00 PM
</div>
<div
class="publishedProfilesInfo"
Expand Down Expand Up @@ -239,7 +239,7 @@ exports[`UploadedRecordingsHome matches a snapshot when rendering published prof
<div
class="publishedProfilesDate"
>
Jul 3, 8:00 AM
Jul 3, 8:00 AM
</div>
<div
class="publishedProfilesInfo"
Expand Down