Remove use of AWS stage server#4652
Merged
Merged
Conversation
This removes the host that pointed to the stage environment in AWS for the Mozilla Symbolication Service. That host no longer works. See https://bugzilla.mozilla.org/show_bug.cgi?id=1836055
willkg
commented
May 31, 2023
| // ----------------- | ||
| // Can be overridden with the URL parameter `symbolServer=SERVERURL`. | ||
| // You can change this to the staging server `https://symbolication.stage.mozaws.net`, | ||
| // or run a local symbol server (for example using profiler-symbol-server [1]) |
Contributor
Author
There was a problem hiding this comment.
Further, the SYMBOL_SERVER_URL constant below should be renamed to SYMBOLICATION_SERVICE_URL since the symbol server is a different thing.
Contributor
There was a problem hiding this comment.
Yeah, looks like we got used to misname this :-)
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4652 +/- ##
=======================================
Coverage 88.47% 88.47%
=======================================
Files 295 295
Lines 26213 26213
Branches 7068 7068
=======================================
Hits 23193 23193
Misses 2809 2809
Partials 211 211
☔ View full report in Codecov by Sentry. |
julienw
approved these changes
Jun 6, 2023
Contributor
Author
|
Thank you! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the host that pointed to the stage environment in AWS for the Mozilla Symbolication Service. That host no longer works.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1836055