Skip to content

Remove use of AWS stage server #4652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julienw merged 2 commits into from
Jun 6, 2023
Merged

Remove use of AWS stage server #4652

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5d43f0
Remove use of AWS stage server
willkg May 31, 2023
ac5e0cf
Merge branch 'main' into patch-2
julienw Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/app-logic/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,7 @@ export const PROFILER_SERVER_ORIGIN = 'https://api.profiler.firefox.com';
// SYMBOL_SERVER_URL
// -----------------
// Can be overridden with the URL parameter `symbolServer=SERVERURL`.
// You can change this to the staging server `https://symbolication.stage.mozaws.net`,
// or run a local symbol server (for example using profiler-symbol-server [1])

@willkg willkg May 31, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further, the SYMBOL_SERVER_URL constant below should be renamed to SYMBOLICATION_SERVICE_URL since the symbol server is a different thing.

@julienw julienw Jun 6, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks like we got used to misname this :-)

// You can change this to run a local symbol server (for example using profiler-symbol-server [1])
// and set it to e.g. 'http://localhost:8000/'.
//
// [1] https://github.com/mstange/profiler-symbol-server/
Expand Down