Speed up filterSamples by taking advantage of sortedness. #4669
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4669 +/- ##
==========================================
+ Coverage 88.47% 88.49% +0.01%
==========================================
Files 295 296 +1
Lines 26300 26317 +17
Branches 7100 7101 +1
==========================================
+ Hits 23270 23289 +19
+ Misses 2818 2816 -2
Partials 212 212
☔ View full report in Codecov by Sentry. |
Contributor
|
Ah I knew we could do something better but couldn't figure out when I reviewed. Thanks! |
mstange
force-pushed
the
faster-filter-samples
branch
2 times, most recently
from
1319b66 to
10d8606
Compare
Contributor
Author
|
I've pulled out |
canova
approved these changes
Jun 20, 2023
canova
left a comment
canova
left a comment
Member
There was a problem hiding this comment.
Oh nice. I knew that it wasn't great to have N * M algorithm. Thanks for making it better!
On the profile from firefox-devtools#4668 this makes filterSamples 10x faster. It changes the algorithm complexity from N * M to N + M, N being the number of samples and M the number of ranges. Before: https://share.firefox.dev/3Ji8qPD After: https://share.firefox.dev/3CAtmxA
mstange
force-pushed
the
faster-filter-samples
branch
from
10d8606 to
d685977
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the profile from #4668 this makes
filterSamples10x faster. It changes the algorithm complexity fromN * MtoN + M, withNbeing the number of samples andMthe number of ranges.Before: https://share.firefox.dev/3Ji8qPD
After: https://share.firefox.dev/3CAtmxA
This PR includes #4670.