Speed up dropFunction by using a typed array instead of a sparse JS array.#4670
Merged
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4670 +/- ##
==========================================
- Coverage 88.47% 88.47% -0.01%
==========================================
Files 295 295
Lines 26299 26290 -9
Branches 7099 7097 -2
==========================================
- Hits 23269 23260 -9
Misses 2818 2818
Partials 212 212
☔ View full report in Codecov by Sentry. |
canova
approved these changes
Jun 19, 2023
canova
left a comment
canova
left a comment
Member
There was a problem hiding this comment.
Noice! It's always great to see how a very small change can have a huge impact! :)
I guess this will increase the memory usage a bit (since we are initializing the whole array now), but it's a very small thing compared to the impact.
…rray. This improves firefox-devtools#4668 from 7.0 seconds to 1.6 seconds. Before: https://share.firefox.dev/3qP8iB3 After: https://share.firefox.dev/43JVAC8
mstange
force-pushed
the
faster-drop-function
branch
from
197e034 to
f7ed6f4
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves #4668 from 7.0 seconds to 1.6 seconds.
Before: https://share.firefox.dev/3qP8iB3
After: https://share.firefox.dev/43JVAC8