Upgrade prettier to v3#4730
Merged
Merged
Conversation
julienw
force-pushed
the
upgrade-prettier-v3
branch
from
3d4ce29 to
c34e6f2
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4730 +/- ##
==========================================
- Coverage 88.34% 88.32% -0.03%
==========================================
Files 299 300 +1
Lines 26727 26732 +5
Branches 7213 7213
==========================================
- Hits 23612 23611 -1
- Misses 2902 2908 +6
Partials 213 213
☔ View full report in Codecov by Sentry. |
julienw
commented
Aug 31, 2023
Comment on lines
+70
to
+72
| | Sample index | Sample's stack | | ||
| | ------------ | ---------------------------------------------------------------------------------------------- | | ||
| | 0 | `JS::RunScript [c++] ➡ onLoad [js] ➡ a [js] ➡ b [js]` | |
Contributor
Author
There was a problem hiding this comment.
For this bad formatting, I filed an issue on the prettier repository: prettier/prettier#15338
canova
approved these changes
Sep 1, 2023
canova
left a comment
canova
left a comment
Member
There was a problem hiding this comment.
Looks good to me, thanks for the upgrade!
Comment on lines
+70
to
+72
| | Sample index | Sample's stack | | ||
| | ------------ | ---------------------------------------------------------------------------------------------- | | ||
| | 0 | `JS::RunScript [c++] ➡ onLoad [js] ➡ a [js] ➡ b [js]` | |
julienw
force-pushed
the
upgrade-prettier-v3
branch
from
c34e6f2 to
93192c1
Compare
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please look at the 3 last commits only, as the 2 first commits are #4727