Run prettier independently from eslint#4727
Merged
Merged
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4727 +/- ##
=======================================
Coverage 88.34% 88.34%
=======================================
Files 299 299
Lines 26726 26726
Branches 7213 7213
=======================================
Hits 23611 23611
Misses 2902 2902
Partials 213 213 ☔ View full report in Codecov by Sentry. |
Merged
julienw
force-pushed
the
split-prettier-eslint
branch
from
8a8baa5 to
9a343bb
Compare
julienw
force-pushed
the
split-prettier-eslint
branch
from
9a343bb to
70af222
Compare
Contributor
Author
|
Thanks! |
julienw
force-pushed
the
split-prettier-eslint
branch
from
70af222 to
0c716c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way we were configuring prettier was useful when prettier wasn't integrated with IDEs much at the time. Nowadays the recommended approach is to run both tools separately.
It's probably better to look at the commits separately.
The only change in a file that doesn't come from prettier is in
res/photon/index.html: it looks like that some</div>were unbalanced.