Skip to content

Use a cache for prettier #4731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julienw merged 1 commit into from
Sep 1, 2023
Merged

Use a cache for prettier #4731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ public_html/
flow-coverage
coverage
.eslintcache
.prettiercache
webpack.local-config.js
*.orig
*.rej
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
"lint-fix-js": "yarn lint-js --fix",
"lint-css": "stylelint \"src/**/*.css\" \"res/**/*.css\"",
"lint-fix-css": "yarn lint-css --fix",
"prettier-run": "prettier --check .",
"prettier-fix": "prettier --write .",
"prettier-run": "prettier --check . --cache --cache-strategy content --cache-location .prettiercache",
"prettier-fix": "prettier --write . --cache --cache-strategy content --cache-location .prettiercache",
Comment on lines +22 to +23

@julienw julienw Aug 25, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default cache location is somewhere in node_modules, I was worried that it might get picked up by the cache happening in the CI. In CI I'd prefer to run without a cache, that's why I thought it would be better to explicitely set this cache location. Note that the eslint cache is in .eslintcache so it looked like a good idea to use a similar name.

@canova canova Sep 1, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I would also like to run the CI without a cache. Also it would be easy to remove the cache from the root directory if we want to, when we are developing locally.

"flow": "flow --max-warnings 0",
"flow:ci": "flow check --max-warnings 0",
"flow-stop": "flow stop",
Expand Down