Use a cache for prettier#4731
Merged
Merged
Conversation
julienw
commented
Aug 25, 2023
Comment on lines
+22
to
+23
| "prettier-run": "prettier --check . --cache --cache-strategy content --cache-location .prettiercache", | ||
| "prettier-fix": "prettier --write . --cache --cache-strategy content --cache-location .prettiercache", |
Contributor
Author
There was a problem hiding this comment.
The default cache location is somewhere in node_modules, I was worried that it might get picked up by the cache happening in the CI. In CI I'd prefer to run without a cache, that's why I thought it would be better to explicitely set this cache location. Note that the eslint cache is in .eslintcache so it looked like a good idea to use a similar name.
Member
There was a problem hiding this comment.
Good idea. I would also like to run the CI without a cache. Also it would be easy to remove the cache from the root directory if we want to, when we are developing locally.
canova
approved these changes
Sep 1, 2023
Comment on lines
+22
to
+23
| "prettier-run": "prettier --check . --cache --cache-strategy content --cache-location .prettiercache", | ||
| "prettier-fix": "prettier --write . --cache --cache-strategy content --cache-location .prettiercache", |
Member
There was a problem hiding this comment.
Good idea. I would also like to run the CI without a cache. Also it would be easy to remove the cache from the root directory if we want to, when we are developing locally.
julienw
force-pushed
the
prettier-cache
branch
from
a43a322 to
b28a5da
Compare
tenderlove
added a commit
to tenderlove/profiler
that referenced
this pull request
Jan 16, 2024
* main: (37 commits) Show the hovered time in the ruler at the top of the timeline. (PR firefox-devtools#4748) Hardcode 'project' to 'firefox-profiler' in .taskcluster.yml (PR firefox-devtools#4759) Update all Yarn dependencies (2023-09-27) (PR firefox-devtools#4758) Update the uploading command in the developer documentation (PR firefox-devtools#4752) Make prettier ignore the taskcluster files Add taskcluster Update all Yarn dependencies (2023-09-20) (PR firefox-devtools#4756) Add a robots.txt file to disallow indexing our profile links (PR firefox-devtools#4753) Avoid showing the calltree panel in profiles without samples. (PR firefox-devtools#4744) Display the vertical line in the timeline when hovering the marker chart or stack chart (PR firefox-devtools#4742) Draw a single rectangle for 2 markers in bar charts only if both the start and end horizontal pixels match. (PR firefox-devtools#4734) Update all Yarn dependencies (2023-09-13) (firefox-devtools#4746) Update all Yarn dependencies (2023-09-06) (PR firefox-devtools#4741) Remove prefer-wait-for rule in our config because it's been removed from the plugin ⬆️ Update eslint-plugin-testing-library to version 6.0.1 Use a cache for prettier (PR firefox-devtools#4731) Remove leftover eslint error Run prettier on the codebase Upgrade prettier to latest version Ignore the coverage directory when present ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up for #4727: by configuring the cache option, this makes running prettier much faster.
Please look at the last commit only.