Support colored power tracks#4760
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4760 +/- ##
==========================================
+ Coverage 88.32% 88.34% +0.01%
==========================================
Files 300 301 +1
Lines 26808 26811 +3
Branches 7241 7244 +3
==========================================
+ Hits 23679 23687 +8
+ Misses 2917 2911 -6
- Partials 212 213 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Looks great, the colors really do make a difference. Also sorry for the delay on the review.
r+ with the GraphColor.js file moved to a better place, see my comment below.
I don't think it needs a re-review as it's a simple git mv with some imports changed, but let me know if you still want another look.
| ctx.strokeStyle = getStrokeColor(TRACK_MEMORY_COLOR); | ||
| ctx.fillStyle = getFillColor(TRACK_MEMORY_COLOR); |
There was a problem hiding this comment.
I like the idea of extracting this to a shared place. But we usually put the React components to src/components/ directory. It looks like this file is a better fit for src/profile-logic directory. Could you move it there? Also we use snake case for non-component files. We can make it graph-color.
8da2e0a to
7acc5c1
Compare
7acc5c1 to
e5b271f
Compare
Profiles with many power tracks could benefit from coloring some of them.
Example profile with colored power tracks: https://share.firefox.dev/3tcfZ5t
Deploy preview.