Support colored bandwidth and memory tracks#5232
Merged
julienw merged 2 commits intoDec 4, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5232 +/- ##
=======================================
Coverage 88.61% 88.62%
=======================================
Files 308 308
Lines 28091 28096 +5
Branches 7613 7619 +6
=======================================
+ Hits 24894 24899 +5
Misses 2983 2983
Partials 214 214 ☔ View full report in Codecov by Sentry. |
epsio-yuval
force-pushed
the
memory-and-bandwidth-track-colors
branch
from
677c240 to
0e4ed36
Compare
julienw
reviewed
Dec 4, 2024
julienw
left a comment
julienw
left a comment
Contributor
There was a problem hiding this comment.
Hey, thanks for the patch!
This looks good to me, but could you also rename TRACK_BANDWIDTH_COLOR and TRACK_MEMORY_COLOR to TRACK_BANDWIDTH_DEFAULT_COLOR and TRACK_MEMORY_DEFAULT_COLOR (to be consistent with TRACK_MARKER_DEFAULT_COLOR)?
epsio-yuval
force-pushed
the
memory-and-bandwidth-track-colors
branch
from
0e4ed36 to
d8bb31b
Compare
epsio-yuval
force-pushed
the
memory-and-bandwidth-track-colors
branch
from
d8bb31b to
c2c1ed3
Compare
Merged
canova
added a commit
that referenced
this pull request
Dec 12, 2024
[Sean Kim] Add Class of Service for a request in the profiler network tab (#5228) [Nisarg Jhaveri] Allow loading gzipped profiles from more endpoints (#5215) [Nicolas Chevobbe] Adapt Tree row toggle button to High Contrast Mode. (#5238) [Jon Coppeard] Display malloc heap size data in GCMajor markers (#5239) [Nicolas Chevobbe] Opt-out of forced-colors for colored-square and colored-border (#5237) [Yuval Mizrachi] Support colored bandwidth and memory tracks (#5232) [Nicolas Chevobbe] Adapt context menu to High Contrast Mode (#5244) [Nazım Can Altınova] Show Chrome extension instructions in the homepage if visited from Chromium browsers (#5251) And thanks to our localizers: de: Michael Köhler en-GB: Ian Neal fr: Théo Chevalier fr: felash fy-NL: Fjoerfoks it: Francesco Lodolo [:flod] nl: Mark Heijl pt-BR: Marcelo Ghelman ru: Valery Ledovskoy uk: Francesco Lodolo [:flod] uk: Markevych Dmytro Vitaliyovych zh-CN: Olvcpr423
tenderlove
pushed a commit
to tenderlove/profiler
that referenced
this pull request
Dec 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend #4760 for bandwidth and memory tracks.