Skip to content

Stop using sampleCallNodes in ThreadSampleGraph.#4809

Merged
mstange merged 1 commit into
firefox-devtools:mainfrom
mstange:no-callnodes-in-thread-sample-graph
Nov 27, 2023
Merged

Stop using sampleCallNodes in ThreadSampleGraph.#4809
mstange merged 1 commit into
firefox-devtools:mainfrom
mstange:no-callnodes-in-thread-sample-graph

Conversation

@mstange

@mstange mstange commented Nov 25, 2023

Copy link
Copy Markdown
Contributor

We just need to know whether a sample was filtered out, so we can check the sample's stack for that.

@mstange mstange requested a review from julienw November 25, 2023 01:01
@mstange mstange self-assigned this Nov 25, 2023
@codecov

codecov Bot commented Nov 25, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (efbe020) 88.27% compared to head (8f3eb30) 88.27%.
Report is 2 commits behind head on main.

❗ Current head 8f3eb30 differs from pull request most recent head 5fc4a4b. Consider uploading reports for the commit 5fc4a4b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4809      +/-   ##
==========================================
- Coverage   88.27%   88.27%   -0.01%     
==========================================
  Files         301      301              
  Lines       26911    26910       -1     
  Branches     7284     7284              
==========================================
- Hits        23755    23754       -1     
  Misses       2938     2938              
  Partials      218      218              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@julienw julienw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, sounds good to me

@mstange mstange force-pushed the no-callnodes-in-thread-sample-graph branch from 8f3eb30 to 5fc4a4b Compare November 27, 2023 20:20
@mstange mstange merged commit 7b888cd into firefox-devtools:main Nov 27, 2023
@julienw julienw mentioned this pull request Dec 5, 2023
@mstange mstange added the perf Issues where the profiler itself is slow. label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

perf Issues where the profiler itself is slow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants