Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions src/components/shared/thread/SampleGraph.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import React, { PureComponent } from 'react';
import classNames from 'classnames';
import { InView } from 'react-intersection-observer';
import { ensureExists } from 'firefox-profiler/utils/flow';
import { timeCode } from 'firefox-profiler/utils/time-code';
import { getSampleIndexClosestToCenteredTime } from 'firefox-profiler/profile-logic/profile-data';
import { bisectionRight } from 'firefox-profiler/utils/bisect';
Expand All @@ -20,7 +19,6 @@ import type {
CategoryList,
IndexIntoSamplesTable,
Milliseconds,
IndexIntoCallNodeTable,
SelectedState,
} from 'firefox-profiler/types';
import type { SizeProps } from 'firefox-profiler/components/shared/WithSize';
Expand All @@ -29,7 +27,6 @@ type Props = {|
+className: string,
+thread: Thread,
+samplesSelectedStates: null | SelectedState[],
+sampleCallNodes: Array<IndexIntoCallNodeTable | null>,
+interval: Milliseconds,
+rangeStart: Milliseconds,
+rangeEnd: Milliseconds,
Expand Down Expand Up @@ -95,7 +92,6 @@ export class ThreadSampleGraphImpl extends PureComponent<Props> {
rangeStart,
rangeEnd,
samplesSelectedStates,
sampleCallNodes,
categories,
width,
height,
Expand Down Expand Up @@ -144,8 +140,8 @@ export class ThreadSampleGraphImpl extends PureComponent<Props> {
if (sampleTime < nextMinTime) {
continue;
}
const callNodeIndex = sampleCallNodes[i];
if (callNodeIndex === null) {
const stackIndex = thread.samples.stack[i];
if (stackIndex === null) {
continue;
}
const xPos =
Expand All @@ -157,10 +153,6 @@ export class ThreadSampleGraphImpl extends PureComponent<Props> {
) {
samplesBucket = highlightedSamples;
} else {
const stackIndex = ensureExists(
thread.samples.stack[i],
'A stack must exist for this sample, since a callNodeIndex exists.'
);
const categoryIndex = thread.stackTable.category[stackIndex];
const category = categories[categoryIndex];
if (category.name === 'Idle') {
Expand Down
1 change: 0 additions & 1 deletion src/components/timeline/TrackThread.js
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,6 @@ class TimelineTrackThreadImpl extends PureComponent<Props> {
thread={filteredThread}
rangeStart={rangeStart}
rangeEnd={rangeEnd}
sampleCallNodes={sampleCallNodes}
samplesSelectedStates={samplesSelectedStates}
categories={categories}
onSampleClick={this._onSampleClick}
Expand Down