Localize title and aria label in ProfileName#5345
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5345 +/- ##
==========================================
- Coverage 86.02% 86.02% -0.01%
==========================================
Files 311 311
Lines 29791 29790 -1
Branches 8217 8217
==========================================
- Hits 25629 25628 -1
Misses 3576 3576
Partials 586 586 ☔ View full report in Codecov by Sentry. |
| className="profileNameButton menuButtonsButton menuButtonsButton-hasRightBorder menuButtonsButton-hasIcon" | ||
| onFocus={this.handleButtonFocus} | ||
| onClick={this.handleButtonFocus} | ||
| <Localized id="ProfileName--profile-name" attrs={{ title: true }}> |
There was a problem hiding this comment.
I believe it would be better to have 2 different ids for the 2 different elements.
What do you think of:
ProfileName--edit-profile-name-button
and
ProfileName--edit-profile-name-input
?
There was a problem hiding this comment.
Done.
I did git commit --amend and git push --force my branch so i do not have the very latest commits.
Shall i add them? If yes, is rebasing main to my branch the way or do i need a merge commit or sth similar?
There was a problem hiding this comment.
Thanks!
Usually we use rebase in this project, but that's not really necessary unless there are conflicts (github should tell when it's happening).
Before merging we do a merge directly with the github interface to get the tests running on the latest code, and then merge from there.
theoniko
force-pushed
the
localize-title-and-aria-label-in-ProfileName
branch
from
dfb4f29 to
cbc545e
Compare
| PanelSearch--search-field-hint = | ||
| Did you know you can use the comma (,) to search using several terms? | ||
|
|
||
| ## Profile Name Button |
There was a problem hiding this comment.
hey @flodolo , do you think this needs some more comments, for example to make explicit that only title and aria-label should be translated, but the string itself should stay empty?
There was a problem hiding this comment.
No need, this will show up in Pontoon as a single input field, hiding the underlying complexity.
See for example https://pontoon.mozilla.org/fr/firefox-profiler/all-resources/?search=FooterLinks--hide-button&search_identifiers=true&string=242768
FooterLinks--hide-button =
.title = Hide footer links
.aria-label = Hide footer links
| PanelSearch--search-field-hint = | ||
| Did you know you can use the comma (,) to search using several terms? | ||
|
|
||
| ## Profile Name Button |
There was a problem hiding this comment.
No need, this will show up in Pontoon as a single input field, hiding the underlying complexity.
See for example https://pontoon.mozilla.org/fr/firefox-profiler/all-resources/?search=FooterLinks--hide-button&search_identifiers=true&string=242768
FooterLinks--hide-button =
.title = Hide footer links
.aria-label = Hide footer links
Updates: [Julien Wajsberg] Some more small refactorings (#5320) [Markus Stange] Pass the correct sample index offset to getTimingsForCallNodeIndex for the flame graph tooltip. (#5328) [Nisarg Jhaveri] Update docs to include Android Studio/Simpleperf trace file support (#5309) [Markus Stange] Don't pass the preview filtered thread to getTimingsForPath/CallNodeIndex. (#5329) [Nazım Can Altınova] Add a "Sample timestamp" field to the sample tooltip in timeline (#5322) [Markus Stange] Reduce confusion between call tree summary strategy aware samples and regular samples (#5330) [Markus Stange] Rename this getCounter selector to getCounters. (#5337) [Markus Stange] Make sample indexes compatible between the unfiltered and (preview) filtered call tree summary strategy samples when using an allocation strat> [Markus Stange] Remove some code that uses the preview filtered thread (#5336) [Markus Stange] Remove getMarkerSchemaName special cases - look up marker schemas from data.type and nothing else (#5293) [Markus Stange] Remove the makeProfileSerializable step - make the raw in-memory profile match the format that's stored in the file (#5287) [Nicolas Chevobbe] Adapt FilterNavigatorBar to High Contrast Mode. (#5257) [Nicolas Chevobbe] Adapt Tracks to High Contrast Mode. (#5252) [Markus Stange] Adjust string index fields in markers when merging threads (#5344) [Theodoros Nikolaou] Localize title and aria label in ProfileName (#5345) [Julien Wajsberg] Adapt time-slice selection in High Contrast Mode. (#5259) [Markus Stange] Make stackTable (sub)category derived data (#5342) [Markus Stange] Compute cpuRatio values when computing the derived thread (#5288) [Nazım Can Altınova] Add a context menu item to open the JS scripts in DevTools debugger (#5295) Also thanks to our localizers: el: Jim Spentzos fr: Théo Chevalier it: Francesco Lodolo [:flod] zh-TW: Pin-guang Chen
3 participants
Fixes #5094