Merged
Conversation
This lines it up with flipper cloud more which I use and love. Hoping others will dig this look too. I'll write up about it upon releasing.
…nto ui-redesign
thetimbanks
reviewed
Jun 16, 2020
Collaborator
thetimbanks
left a comment
thetimbanks
left a comment
There was a problem hiding this comment.
Overall this looks great! Just a few small comments.
Collaborator
Author
|
@thetimbanks I really appreciate you taking the time to look this over and so quickly. Thanks! I'll tweak up anything you suggest and we can go from there. |
Too much overhead for a few lines of css and js. This also removed some outdated files in the public folder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been 100% using flipper cloud at this point but when I go back to the OSS UI I miss cloud, so I thought I'd spend some time refreshing the OSS version to work/look a bit more like it.
Old Features List
A wall of text.
New Features List
Compact and succinct. In one quick look you can tell exactly how the feature is enabled without having to dive into the show view.
Old Feature Show
Everything you could possibly want to do all shown to you at once.
New Feature Show
Again, succinct. Add an actor/group or change a % is just a click, but you get a much more simple view now. No longer does the danger zone draw your eye, but it is still there if you need it.
When fully enabled, all the other gates are hidden to keep the view even more simple and obvious.
Wrap Up
This also all works nicely on mobile from my testing. Open to any thoughts/review and I'll probably merge and cut a new release soon.