Skip to content

UI Redesign #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnunemaker merged 10 commits into from
Jun 17, 2020
Merged

UI Redesign #470

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
64e46aa
Redesign UI to be more slick/compact
jnunemaker Jun 14, 2020
a6cc08e
Get the specs passing
jnunemaker Jun 14, 2020
f41f0d4
Fix js syntax
jnunemaker Jun 14, 2020
448de7c
A bit of margin between squirrel and text
jnunemaker Jun 16, 2020
ca2cd78
Remove now unused options
jnunemaker Jun 16, 2020
034996a
Remove now unused options
jnunemaker Jun 16, 2020
ac1990d
Merge branch 'ui-redesign' of https://github.com/jnunemaker/flipper i…
jnunemaker Jun 16, 2020
f032c22
Fix default sqlite version for default rails version
jnunemaker Jun 17, 2020
b2fa5e6
Remove sass and coffeescript
jnunemaker Jun 17, 2020
011e63d
Switch to class for max width to avoid inline style
jnunemaker Jun 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove now unused options
  • Loading branch information
@jnunemaker
jnunemaker committed Jun 16, 2020
commit ca2cd787937e28acc40f2061c04da49e1d36f8e7
10 changes: 1 addition & 9 deletions lib/flipper/ui/configuration.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,7 @@
module Flipper
module UI
class Configuration
attr_reader :actors,
:delete,
:groups,
:percentage_of_actors,
:percentage_of_time
attr_reader :delete

attr_accessor :banner_text,
:banner_class
Expand Down Expand Up @@ -54,10 +50,6 @@ class Configuration
DEFAULT_DESCRIPTIONS_SOURCE = ->(_keys) { {} }

def initialize
@actors = Option.new("Actors", "Enable actors using the form above.")
@groups = Option.new("Groups", "Enable groups using the form above.")
@percentage_of_actors = Option.new("Percentage of Actors", "Percentage of actors functions independently of percentage of time. If you enable 50% of Actors and 25% of Time then the feature will always be enabled for 50% of users and occasionally enabled 25% of the time for everyone.")
@percentage_of_time = Option.new("Percentage of Time", "Percentage of actors functions independently of percentage of time. If you enable 50% of Actors and 25% of Time then the feature will always be enabled for 50% of users and occasionally enabled 25% of the time for everyone.")
@delete = Option.new("Danger Zone", "Deleting a feature removes it from the list of features and disables it for everyone.")
@banner_text = nil
@banner_class = 'danger'
Expand Down