command: fix NoMethodError of --daemon under Windows - #4716
Merged
Conversation
Watson1978
force-pushed
the
windows/daemon
branch
2 times, most recently
from
November 26, 2024 06:15
42435bf to
ace524e
Compare
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Watson1978
force-pushed
the
windows/daemon
branch
from
November 26, 2024 06:31
ace524e to
12f04ff
Compare
Watson1978
changed the title
Watson1978
marked this pull request as ready for review
November 26, 2024 06:32
Contributor
|
Thanks! Note:
|
daipom
changed the title
daipom
changed the title
daipom
pushed a commit
that referenced
this pull request
Jan 29, 2025
…4796) **Which issue(s) this PR fixes**: Backport #4716 **What this PR does / why we need it**: To daemonize the process, the following code will be invoked on Windows: https://github.com/fluent/fluentd/blob/89f0a76fb2e050659f0a503823beb2ad8cf899eb/lib/fluent/daemon.rb#L13 $log variable does not exist because it has not executed `Superviser#setup_global_logger` method until here. It will perform a new startup process and prepare a logger in https://github.com/fluent/fluentd/blob/89f0a76fb2e050659f0a503823beb2ad8cf899eb/lib/fluent/daemon.rb#L13 This patch will only avoid the error since a logger is not required this process. **Docs Changes**: Not needed. **Release Note**: The same as the title. Signed-off-by: Shizuo Fujita <fujita@clear-code.com> Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com> Co-authored-by: Watson <fujita@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #4354
What this PR does / why we need it:
To daemonize the process, the following code will be invoked on Windows:
fluentd/lib/fluent/daemon.rb
Line 13 in 89f0a76
$log variable does not exist because it has not executed
Superviser#setup_global_loggermethod until here.It will perform a new startup process and prepare a logger in
fluentd/lib/fluent/daemon.rb
Line 13 in 89f0a76
This patch will only avoid the error since a logger is not required this process.
Docs Changes:
Not needed.
Release Note:
The same as the title.