Skip to content

Backport(v1.16) command: fix NoMethodError of --daemon under Windows - #4796

Merged
daipom merged 1 commit into
v1.16from
backport-pr4716
Jan 29, 2025
Merged

Backport(v1.16) command: fix NoMethodError of --daemon under Windows#4796
daipom merged 1 commit into
v1.16from
backport-pr4716

Conversation

@kenhys

@kenhys kenhys commented Jan 29, 2025

Copy link
Copy Markdown
Contributor

Which issue(s) this PR fixes:

Backport #4716

What this PR does / why we need it:
To daemonize the process, the following code will be invoked on Windows:

ServerEngine::Daemon.run_server(server_module, worker_module) { Fluent::Supervisor.serverengine_config(params) }

$log variable does not exist because it has not executed Superviser#setup_global_logger method until here.
It will perform a new startup process and prepare a logger in

ServerEngine::Daemon.run_server(server_module, worker_module) { Fluent::Supervisor.serverengine_config(params) }

This patch will only avoid the error since a logger is not required this process.

Docs Changes:
Not needed.

Release Note:
The same as the title.

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
@kenhys

kenhys commented Jan 29, 2025

Copy link
Copy Markdown
Contributor Author
git switch -c backport-pr4716 --track origin/v1.16
git cherry-pick 713b738d9ac4a9321bbeb550b415311a6478747b

@daipom daipom added this to the v1.16.7 milestone Jan 29, 2025
@daipom
daipom merged commit fc5ece8 into v1.16 Jan 29, 2025
@daipom
daipom deleted the backport-pr4716 branch January 29, 2025 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants