Skip to content

test_in_tail: add wait to detect rotation - #4874

Merged
daipom merged 1 commit into
fluent:masterfrom
Watson1978:ci/test_in_tail
Mar 19, 2025
Merged

test_in_tail: add wait to detect rotation#4874
daipom merged 1 commit into
fluent:masterfrom
Watson1978:ci/test_in_tail

Conversation

@Watson1978

@Watson1978 Watson1978 commented Mar 19, 2025

Copy link
Copy Markdown
Contributor

Which issue(s) this PR fixes:
Fixes #4079

What this PR does / why we need it:
For reasons such as the load on the CI execution environment, looks like that rotation detection is delayed and the test does not execute as expected.

For this reason, this patch adds a wait to ensure to detect the rotation.

Before the patch was introduced, tests failed about once every 20 to 50 times.
After, the test was successful 500 consecutive times.

Docs Changes:

Release Note:

@Watson1978 Watson1978 added the CI Test/CI issues label Mar 19, 2025
@Watson1978
Watson1978 requested a review from daipom March 19, 2025 07:50
@Watson1978
test_in_tail: add wait to detect rotation
0d02743 
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
daipom
daipom approved these changes Mar 19, 2025
View reviewed changes

@daipom daipom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@daipom daipom added this to the v1.19.0 milestone Mar 19, 2025
@daipom daipom added the backport to v1.16 We will backport this fix to the LTS branch label Mar 19, 2025
@daipom
daipom merged commit f34a253 into fluent:master Mar 19, 2025
@Watson1978
Watson1978 deleted the ci/test_in_tail branch March 19, 2025 09:42
kenhys pushed a commit to kenhys/fluentd that referenced this pull request Apr 23, 2025
@Watson1978 @kenhys
test_in_tail: add wait to detect rotation (fluent#4874)
c015ef2 
**Which issue(s) this PR fixes**:
Fixes fluent#4079

**What this PR does / why we need it**:
For reasons such as the load on the CI execution environment, looks like
that rotation detection is delayed and the test does not execute as
expected.

For this reason, this patch adds a wait to ensure to detect the
rotation.

Before the patch was introduced, tests failed about once every 20 to 50
times.
After, the test was successful  500 consecutive times.

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys pushed a commit to kenhys/fluentd that referenced this pull request Apr 23, 2025
@Watson1978 @kenhys
test_in_tail: add wait to detect rotation (fluent#4874)
46efadd 
**Which issue(s) this PR fixes**:
Fixes fluent#4079

**What this PR does / why we need it**:
For reasons such as the load on the CI execution environment, looks like
that rotation detection is delayed and the test does not execute as
expected.

For this reason, this patch adds a wait to ensure to detect the
rotation.

Before the patch was introduced, tests failed about once every 20 to 50
times.
After, the test was successful  500 consecutive times.

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys pushed a commit to kenhys/fluentd that referenced this pull request Apr 23, 2025
@Watson1978 @kenhys
test_in_tail: add wait to detect rotation (fluent#4874)
2ba17d1 
**Which issue(s) this PR fixes**:
Fixes fluent#4079

**What this PR does / why we need it**:
For reasons such as the load on the CI execution environment, looks like
that rotation detection is delayed and the test does not execute as
expected.

For this reason, this patch adds a wait to ensure to detect the
rotation.

Before the patch was introduced, tests failed about once every 20 to 50
times.
After, the test was successful  500 consecutive times.

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys pushed a commit to kenhys/fluentd that referenced this pull request Apr 23, 2025
@Watson1978 @kenhys
test_in_tail: add wait to detect rotation (fluent#4874)
9b5fe81 
**Which issue(s) this PR fixes**:
Fixes fluent#4079

**What this PR does / why we need it**:
For reasons such as the load on the CI execution environment, looks like
that rotation detection is delayed and the test does not execute as
expected.

For this reason, this patch adds a wait to ensure to detect the
rotation.

Before the patch was introduced, tests failed about once every 20 to 50
times.
After, the test was successful  500 consecutive times.

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys pushed a commit to kenhys/fluentd that referenced this pull request Apr 23, 2025
@Watson1978 @kenhys
test_in_tail: add wait to detect rotation (fluent#4874)
492dd1b 
**Which issue(s) this PR fixes**:
Fixes fluent#4079

**What this PR does / why we need it**:
For reasons such as the load on the CI execution environment, looks like
that rotation detection is delayed and the test does not execute as
expected.

For this reason, this patch adds a wait to ensure to detect the
rotation.

Before the patch was introduced, tests failed about once every 20 to 50
times.
After, the test was successful  500 consecutive times.

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys pushed a commit to kenhys/fluentd that referenced this pull request Apr 23, 2025
@Watson1978 @kenhys
test_in_tail: add wait to detect rotation (fluent#4874)
0266873 
**Which issue(s) this PR fixes**:
Fixes fluent#4079

**What this PR does / why we need it**:
For reasons such as the load on the CI execution environment, looks like
that rotation detection is delayed and the test does not execute as
expected.

For this reason, this patch adds a wait to ensure to detect the
rotation.

Before the patch was introduced, tests failed about once every 20 to 50
times.
After, the test was successful  500 consecutive times.

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys pushed a commit to kenhys/fluentd that referenced this pull request Apr 23, 2025
@Watson1978 @kenhys
test_in_tail: add wait to detect rotation (fluent#4874)
9c78bde 
**Which issue(s) this PR fixes**:
Fixes fluent#4079

**What this PR does / why we need it**:
For reasons such as the load on the CI execution environment, looks like
that rotation detection is delayed and the test does not execute as
expected.

For this reason, this patch adds a wait to ensure to detect the
rotation.

Before the patch was introduced, tests failed about once every 20 to 50
times.
After, the test was successful  500 consecutive times.

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys pushed a commit to kenhys/fluentd that referenced this pull request Apr 23, 2025
@Watson1978 @kenhys
test_in_tail: add wait to detect rotation (fluent#4874)
81f810e 
**Which issue(s) this PR fixes**:
Fixes fluent#4079

**What this PR does / why we need it**:
For reasons such as the load on the CI execution environment, looks like
that rotation detection is delayed and the test does not execute as
expected.

For this reason, this patch adds a wait to ensure to detect the
rotation.

Before the patch was introduced, tests failed about once every 20 to 50
times.
After, the test was successful  500 consecutive times.

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys pushed a commit to kenhys/fluentd that referenced this pull request Apr 23, 2025
@Watson1978 @kenhys
test_in_tail: add wait to detect rotation (fluent#4874)
4643b1d 
**Which issue(s) this PR fixes**:
Fixes fluent#4079

**What this PR does / why we need it**:
For reasons such as the load on the CI execution environment, looks like
that rotation detection is delayed and the test does not execute as
expected.

For this reason, this patch adds a wait to ensure to detect the
rotation.

Before the patch was introduced, tests failed about once every 20 to 50
times.
After, the test was successful  500 consecutive times.

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
@kenhys kenhys mentioned this pull request Apr 23, 2025
Closed
kenhys pushed a commit to kenhys/fluentd that referenced this pull request Apr 23, 2025
@Watson1978 @kenhys
test_in_tail: add wait to detect rotation (fluent#4874)
edebaa7 
**Which issue(s) this PR fixes**:
Fixes fluent#4079

**What this PR does / why we need it**:
For reasons such as the load on the CI execution environment, looks like
that rotation detection is delayed and the test does not execute as
expected.

For this reason, this patch adds a wait to ensure to detect the
rotation.

Before the patch was introduced, tests failed about once every 20 to 50
times.
After, the test was successful  500 consecutive times.

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
@kenhys kenhys mentioned this pull request Apr 23, 2025
Closed
kenhys pushed a commit to kenhys/fluentd that referenced this pull request Apr 23, 2025
@Watson1978 @kenhys
test_in_tail: add wait to detect rotation (fluent#4874)
d29755c 
**Which issue(s) this PR fixes**:
Fixes fluent#4079

**What this PR does / why we need it**:
For reasons such as the load on the CI execution environment, looks like
that rotation detection is delayed and the test does not execute as
expected.

For this reason, this patch adds a wait to ensure to detect the
rotation.

Before the patch was introduced, tests failed about once every 20 to 50
times.
After, the test was successful  500 consecutive times.

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
@kenhys kenhys mentioned this pull request Apr 23, 2025
Closed
kenhys pushed a commit to kenhys/fluentd that referenced this pull request Apr 24, 2025
@Watson1978 @kenhys
test_in_tail: add wait to detect rotation (fluent#4874)
c1f0f8c 
**Which issue(s) this PR fixes**:
Fixes fluent#4079

**What this PR does / why we need it**:
For reasons such as the load on the CI execution environment, looks like
that rotation detection is delayed and the test does not execute as
expected.

For this reason, this patch adds a wait to ensure to detect the
rotation.

Before the patch was introduced, tests failed about once every 20 to 50
times.
After, the test was successful  500 consecutive times.

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
This was referenced Apr 24, 2025
Closed
Closed
kenhys pushed a commit to kenhys/fluentd that referenced this pull request Apr 24, 2025
@Watson1978 @kenhys
test_in_tail: add wait to detect rotation (fluent#4874)
9a15e6d 
**Which issue(s) this PR fixes**:
Fixes fluent#4079

**What this PR does / why we need it**:
For reasons such as the load on the CI execution environment, looks like
that rotation detection is delayed and the test does not execute as
expected.

For this reason, this patch adds a wait to ensure to detect the
rotation.

Before the patch was introduced, tests failed about once every 20 to 50
times.
After, the test was successful  500 consecutive times.

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
@kenhys kenhys mentioned this pull request Apr 24, 2025
Closed
kenhys pushed a commit to kenhys/fluentd that referenced this pull request Apr 24, 2025
@Watson1978 @kenhys
test_in_tail: add wait to detect rotation (fluent#4874)
68f1c08 
**Which issue(s) this PR fixes**:
Fixes fluent#4079

**What this PR does / why we need it**:
For reasons such as the load on the CI execution environment, looks like
that rotation detection is delayed and the test does not execute as
expected.

For this reason, this patch adds a wait to ensure to detect the
rotation.

Before the patch was introduced, tests failed about once every 20 to 50
times.
After, the test was successful  500 consecutive times.

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
@kenhys kenhys mentioned this pull request Apr 24, 2025
Merged
daipom pushed a commit that referenced this pull request Apr 25, 2025
@kenhys @Watson1978
Backport(v1.16): test_in_tail: add wait to detect rotation (#4874) (#…
bd34eaf 
…4925)

**Which issue(s) this PR fixes**: 
Backport #4874
Fixes #4079

**What this PR does / why we need it**: 
For reasons such as the load on the CI execution environment, looks like
that rotation detection is delayed and the test does not execute as
expected.

For this reason, this patch adds a wait to ensure to detect the
rotation.

Before the patch was introduced, tests failed about once every 20 to 50
times.
After, the test was successful  500 consecutive times.

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Co-authored-by: Shizuo Fujita <fujita@clear-code.com>
@daipom daipom added the backported "backport to LTS" is done label Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daipom daipom daipom approved these changes

Assignees

No one assigned

Labels

backport to v1.16 We will backport this fix to the LTS branch backported "backport to LTS" is done CI Test/CI issues

Projects

None yet

Milestone

v1.19.0

Development

Successfully merging this pull request may close these issues.

CI: The test_unwatched_files_should_be_removed test fails sometimes

2 participants

@Watson1978 @daipom