Backport(v1.16): test_in_tail: add wait to detect rotation (#4874) - #4916
Closed
kenhys wants to merge 1 commit into
Closed
Backport(v1.16): test_in_tail: add wait to detect rotation (#4874)#4916kenhys wants to merge 1 commit into
kenhys wants to merge 1 commit into
Conversation
**Which issue(s) this PR fixes**: Fixes fluent#4079 **What this PR does / why we need it**: For reasons such as the load on the CI execution environment, looks like that rotation detection is delayed and the test does not execute as expected. For this reason, this patch adds a wait to ensure to detect the rotation. Before the patch was introduced, tests failed about once every 20 to 50 times. After, the test was successful 500 consecutive times. **Docs Changes**: **Release Note**: Signed-off-by: Shizuo Fujita <fujita@clear-code.com> Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Backport #4874
Fixes #4079
What this PR does / why we need it:
For reasons such as the load on the CI execution environment, looks like that rotation detection is delayed and the test does not execute as expected.
For this reason, this patch adds a wait to ensure to detect the rotation.
Before the patch was introduced, tests failed about once every 20 to 50 times.
After, the test was successful 500 consecutive times.
Docs Changes:
Release Note: