[camera_android_camerax] Migrate check-readiness skill from bash to Dart by reidbaker · Pull Request #11943 · flutter/packages

reidbaker · 2026-06-18T23:41:54Z

1. Migrated `check-readiness` Skill to Dart

Replaced scripts/check.sh with a Dart implementation.
Implemented unit tests for the checker logic under test/check_test.dart

2. Tooling & CI Support for Agent Skills

Static Analysis (Opt-in): Added a new --analyze-skills-for flag to the analyze command. When set, it explicitly runs dart analyze on the .agents/skills directories of the configured packages.
CI Configuration: Configured the global analyze workflow in .ci/targets/analyze.yaml to run analysis on camera's skills via script/configs/skills_analysis.yaml.
Unit Testing: Because .agents/skills/check-readiness is set up as a standalone Dart package with its own pubspec.yaml, the repository's existing dart-test command automatically discovers and runs its unit tests.
Validation Exemption: Added .pubignore parsing support to RepositoryPackage and integrated it into the validate command. Any subpackage matching .pubignore patterns (e.g. .agents/skills/) is now skipped by the validate command, ensuring internal/contributor-only tools do not fail publishing hygiene checks.
Versioning & CHANGELOG Exemption: Classified paths starting with .agents/ as developer-only changes. This exempts skill-only or script-only modifications within the .agents/ directory from triggering version-bump and CHANGELOG update requirements.

I asked my agent to articulate the interaction between top level packages tool commands and .agents/skills. Then I filtered the list to the command I thought reviewers or people looking at this pr later would find interesting.

Interaction of Packages Tool Commands with `.agents/skills`

Command	Targeting Scope	Runs on `.agents/skills`?	Interaction Details
`analyze`	`topLevelOnly`	Yes (Explicitly)	Runs `pub get` on the main package and all subpackages (including those in `.agents/skills`). If the main package is listed in `--analyze-skills-for` (configured in CI via `script/configs/skills_analysis.yaml`), it explicitly runs `dart analyze --fatal-infos .agents/skills`.
`validate`	`includeAllSubpackages`	No (Skipped)	Since `.pubignore` specifies `.agents/`, the skill packages are marked as ignored (`isPubIgnored = true`). The `validate` command skips them entirely (`SKIPPING: Ignored by .pubignore`), exempting developer-only helper tools from public-facing package hygiene rules.
`dart-test`	`includeAllSubpackages`	Yes	Because it targets all subpackages, it scans `.agents/skills/*`. If a skill package contains a `test/` directory, it executes the Dart/Flutter unit tests inside it.
`format`	`topLevelOnly`	Yes	Uses recursive file gathering (`getFilesForPackage`) under the main package directory, formatting all Dart, C++, Java, Kotlin, and Swift files under `.agents/skills/`. It does not filter files using `.pubignore`.
`license-check`	N/A (Repository-wide)	Yes	Gathers all tracked files in Git via `git ls-files`. Any file checked into Git under `.agents/skills/` is validated for standard first-party or recognized third-party license headers.
`fix`	`includeAllSubpackages`	Yes	Runs `dart fix --apply` inside any skill package directory that contains a `pubspec.yaml`.
`update-dependency`	`includeAllSubpackages`	Yes	If a targeted dependency is used by the skill package, its `pubspec.yaml` will be updated.
`update-min-sdk`	`includeAllSubpackages`	Yes	Updates SDK constraints inside the skill package's `pubspec.yaml` when run.
`remove-dev-dependencies`	`includeAllSubpackages`	Yes	Removes development dependencies from the skill package's `pubspec.yaml` when targeted.
`publish-check`	`topLevelOnly`	No	Runs on the main package. Because `.agents/` is listed in `.pubignore`, the directory is excluded from the package archive and not uploaded or checked.
`publish`	`topLevelOnly`	No	Similar to `publish-check`, the `.agents/` directory is skipped during publish due to `.pubignore`.
`fetch-deps`	`topLevelOnly`	No	N/A
`list`	N/A	No	Lists only top-level packages.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩²

- Add dart_skills_lint dependency and configuration - Create .agents/skills and skills directories with documentation - Set up isolated third_party skills installation for remote skills - Symlink remote skills into .agents/skills - Add validate_skills_test.dart for CI integration

…ments

…sInternalRule

gemini-code-assist

Code Review

This pull request introduces a new local agent skill check-readiness to verify the environment, adds a custom lint rule to enforce that tracked skills are marked as internal, and implements proxy tests to run unit tests and validate skills. It also integrates several third-party skills via symlinks. The review feedback highlights several critical improvements: ensuring dependencies are resolved with pub get before running tests, avoiding crashes on broken symlinks by setting followLinks: false, adding safe type checks before casting YAML to a map, using Directory.current.path to robustly determine the workspace root, handling ProcessException when executing git commands, and updating the skill documentation to reference the Dart implementation instead of the duplicate bash script.

- Relocate check.dart from bin/ to tool/ and update workspace root resolution. - Swap pubspec.yaml dependencies and dev_dependencies ordering in check-readiness. - Support analyze_skills package-level configuration in ci_config.yaml. - Remove --analyze-skills-for command line flag and global skills_analysis.yaml config. - Fix doc comment in repository_package.dart. - Refactor AnalyzeCommand to avoid early returns and reuse package-level config. - Fix lint issue in analyze_command.dart.

…s to prevent regression

reidbaker

Code review feedback.

reidbaker · 2026-06-30T19:07:39Z

+    if (!libOnly && _packagesWithSkills.contains(package.directory.basename)) {
+      final List<String> skillsErrors = _validateAgentsSkillsDirectory(package);
+      if (skillsErrors.isNotEmpty) {
+        return PackageResult.fail(skillsErrors);


Changed the callsite, I also modified the readiness checker script to follow the same logic. We now check each tool even if the previous ones fail (and added a test to enforce that behavior)

stuartmorgan-g

LGTM with some comment nits

stuartmorgan-g · 2026-06-30T19:28:57Z

+    if (skillsExitCode != 0) {
+      errors.add('Skills analysis failed');
+    }
+    errors.addAll(skillsErrors);


Optional: This could just be:

final errors = <Stirng>[ if (mainExitCode != 0) 'Main package analysis failed', if (skillsExitCode != 0) 'Skills analysis failed', ...skillsErrors, ];

Thank you this is easier to read

…ization

auto-submit · 2026-06-30T20:34:18Z

autosubmit label was removed for flutter/packages/11943, because - The status or check suite Linux_web web_dart_unit_test_wasm_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2026-06-30T21:27:01Z

autosubmit label was removed for flutter/packages/11943, because - The status or check suite Mac_arm64 ios_platform_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite Mac_arm64 macos_platform_tests master - packages has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux_android android_platform_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

Adds a style guideline to `AGENTS.md` advising agents and developers against adding redundant or trivial comments that simply restate code logic in English. This has been a pattern in my own observations and also was caught by stuart in #11943 after I missed it in my pre review. We currently have no evals so there is not a good way to test this change. ## Pre-Review Checklist This PR is exempt from version/CHANGELOG updates and tests because it only modifies repository-wide guide documentation. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

…er#188863) flutter/packages@274ed3e...e742106 2026-07-01 rmolivares@renzo-olivares.dev [cupertino_ui] Re-enable `tab_scaffold_test.dart` (flutter/packages#12064) 2026-07-01 jmccandless@google.com [material_ui] Port flutter/flutter flutter#184808 "Remove semantics_tester import from card_test.dart" (flutter/packages#11965) 2026-07-01 rmolivares@renzo-olivares.dev [cupertino_ui] Migrate `sliding_segmented_control_test.dart` to `SemanticsHandle` (flutter/packages#11979) 2026-07-01 rmolivares@renzo-olivares.dev [cupertino_ui] Migrate `route_test.dart` to `SemanticsHandle` (flutter/packages#11993) 2026-07-01 rmolivares@renzo-olivares.dev [cupertino_ui] Migrate `nav_bar_test.dart` to `SemanticsHandle` (flutter/packages#11980) 2026-07-01 rmolivares@renzo-olivares.dev [cupertino_ui] Migrate `segmented_control_test.dart` to `SemanticsHandle` (flutter/packages#11982) 2026-07-01 rmolivares@renzo-olivares.dev [cupertino_ui] Re-enable `text_field_test.dart` (flutter/packages#12067) 2026-06-30 r.anantheswar@gmail.com [camera_android_camerax] Pass targetVideoEncodingBitRate to Recorder (flutter/packages#11960) 2026-06-30 1063596+reidbaker@users.noreply.github.com [camera_android_camerax] Migrate check-readiness skill from bash to Dart (flutter/packages#11943) 2026-06-30 21270878+elliette@users.noreply.github.com [material_ui] Enable `time_picker_test` (flutter/packages#12061) 2026-06-30 36861262+QuncCccccc@users.noreply.github.com [cupertino_ui] Migrate checkbox_test.dart to SemanticsHandle (flutter/packages#12065) 2026-06-30 64674824+yashas-hm@users.noreply.github.com [image_picker] Handle limit: 1 in pickMultiImage and pickMultipleMedia gracefully (flutter/packages#11825) 2026-06-30 faheemabbas766@gmail.com [cross_file] Document native mimeType behavior (flutter/packages#11662) 2026-06-30 36861262+QuncCccccc@users.noreply.github.com [material_ui] Remove `image_data.dart` imports from `circle_avatar_test.dart`, `color_scheme_test.dart` (flutter/packages#12059) 2026-06-30 36861262+QuncCccccc@users.noreply.github.com [cupertino_ui] Remove `image_data.dart` import from `scaffold_test.dart` (flutter/packages#12060) 2026-06-30 36861262+QuncCccccc@users.noreply.github.com [cupertino_ui] Remove widgets import from menu_anchor_test.dart (flutter/packages#12068) 2026-06-30 21270878+elliette@users.noreply.github.com [material_ui] Enable `checkbox_list_tile_test` (flutter/packages#12007) 2026-06-30 louisehsu@google.com [in_app_purchase_storekit] Expose quantity in Transactions (flutter/packages#11879) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

reidbaker added 13 commits June 17, 2026 16:49

feat: Add check-readiness skill

26b37ae

feat: Add local check-readiness skill and configure linter

d825767

test: ensure tracked skills cannot be published accidentally

f7f0646

build: pin dart_skills_lint to support individual_skills

ea27e43

test: rewrite tracked skills test to use ValidationSession API

9ac31a2

test: fix analyzer warnings

87cfaf1

build: update dart_skills_lint to 8f85e82b on main

acbcc3e

test: rewrite tracked skills test to use yaml parsing, address PR com…

7eabf5f

…ments

test: revert yaml parsing, use public ValidationSession from repo

9e0d9e5

test: revert to ValidationSession and use ignore implementation_imports

6b68664

test: replace yaml parsing with custom skill rule EnforceTrackedSkill…

0942453

…sInternalRule

test: extract EnforceTrackedSkillsInternalRule to its own file with docs

9471107

flutter-dashboard Bot added the CICD Run CI/CD label Jun 18, 2026

reidbaker marked this pull request as draft June 18, 2026 23:41

github-actions Bot added the p: camera label Jun 18, 2026

gemini-code-assist Bot reviewed Jun 18, 2026

View reviewed changes

ci: allow dart_skills_lint in packages

c4e832f

reidbaker mentioned this pull request Jun 18, 2026

[camera_android_camerax] Setup agent skills camerax #11930

Merged

11 tasks

test: fix internal rule validation feedback

acc34a5

reidbaker force-pushed the convert-check-sh-to-dart branch from e1801ee to d98795b Compare June 19, 2026 00:03

github-actions Bot removed the CICD Run CI/CD label Jun 19, 2026

flutter-dashboard Bot added the CICD Run CI/CD label Jun 19, 2026

reidbaker requested a review from camsim99 June 19, 2026 17:46

github-actions Bot removed the CICD Run CI/CD label Jun 19, 2026

reidbaker added the CICD Run CI/CD label Jun 19, 2026

reidbaker added 4 commits June 19, 2026 13:56

Fix missing copyright headers in check-readiness agent skill

288e5ec

Support .pubignore in publish-check

43be3d1

Add tests for publish_check pubignore parsing

8d17949

Fix .gitignore for check-readiness skill and symlinked skills

81c1c52

reidbaker added 6 commits June 30, 2026 14:39

Address feedback on check-readiness root resolution and add unit test…

1a330b2

…s to prevent regression

Improve failure summary details for analyze command

b6ace4d

Add regression test for both main and skills analyze failures

8604918

Fix omit_obvious_local_variable_types lint in analyze_command.dart

4db9387

Refactor checkReadiness to report all failures and avoid early exit

bf182b1

reidbaker commented Jun 30, 2026

View reviewed changes

reidbaker added the CICD Run CI/CD label Jun 30, 2026

reidbaker requested a review from stuartmorgan-g June 30, 2026 19:08

reidbaker mentioned this pull request Jun 30, 2026

New dashboard checks have stale state when tests are queued flutter/flutter#188810

Open

4 tasks

stuartmorgan-g approved these changes Jun 30, 2026

View reviewed changes

Address stuartmorgan-g feedback on check_readiness and errors initial…

7840313

…ization

github-actions Bot removed the CICD Run CI/CD label Jun 30, 2026

Inline _canRunCommand helper in ReadinessChecker

7299da7

reidbaker mentioned this pull request Jun 30, 2026

[repo] Add comment style guideline to AGENTS.md #12077

Merged

8 tasks

reidbaker added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Jun 30, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 30, 2026

Restrict check-readiness tests to VM platform via dart_test.yaml

e1fc69a

github-actions Bot removed the CICD Run CI/CD label Jun 30, 2026

reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 30, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 30, 2026

reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 30, 2026

auto-submit Bot merged commit bdb1682 into main Jun 30, 2026
88 checks passed

auto-submit Bot deleted the convert-check-sh-to-dart branch June 30, 2026 22:14

engine-flutter-autoroll mentioned this pull request Jul 1, 2026

Roll Packages from 274ed3e0f9f6 to e74210630ab8 (18 revisions) flutter/flutter#188863

Merged

Uh oh!

Conversation

reidbaker commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

1. Migrated check-readiness Skill to Dart

2. Tooling & CI Support for Agent Skills

Interaction of Packages Tool Commands with .agents/skills

Pre-Review Checklist

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

reidbaker left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

reidbaker Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

reidbaker Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

auto-submit Bot commented Jun 30, 2026

Uh oh!

auto-submit Bot commented Jun 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

reidbaker commented Jun 18, 2026 •

edited

Loading

1. Migrated `check-readiness` Skill to Dart

Interaction of Packages Tool Commands with `.agents/skills`