[cupertino_ui] Migrate segmented_control_test.dart to SemanticsHandle#11982
Merged
auto-submit[bot] merged 3 commits intoJul 1, 2026
Conversation
github-actions
Bot
added
the
triage-framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request unskips the segmented control test file and refactors the semantics test to use SemanticsHandle and individual semantics assertions instead of SemanticsTester. The reviewer identified that find.semantics is not a valid property on CommonFinders and recommended using find.bySemanticsLabel instead for the assertions.
| ignoreId: true, | ||
| ignoreRect: true, | ||
| ignoreTransform: true, | ||
| find.semantics.byLabel('Child 1'), |
Contributor
There was a problem hiding this comment.
The find.semantics property does not exist on CommonFinders. To find a widget by its semantics label, use find.bySemanticsLabel instead.
find.bySemanticsLabel('Child 1'),
Contributor
Author
There was a problem hiding this comment.
find.semantics does exist.
|
|
||
| // Assert Child 2 (unselected) | ||
| expect( | ||
| find.semantics.byLabel('Child 2'), |
Contributor
There was a problem hiding this comment.
The find.semantics property does not exist on CommonFinders. To find a widget by its semantics label, use find.bySemanticsLabel instead.
find.bySemanticsLabel('Child 2'),
Contributor
Author
There was a problem hiding this comment.
find.semantics does exist.
| ignoreId: true, | ||
| ignoreRect: true, | ||
| ignoreTransform: true, | ||
| find.semantics.byLabel('Child 1'), |
Contributor
There was a problem hiding this comment.
The find.semantics property does not exist on CommonFinders. To find a widget by its semantics label, use find.bySemanticsLabel instead.
find.bySemanticsLabel('Child 1'),
Contributor
Author
There was a problem hiding this comment.
find.semantics does exist.
|
|
||
| // Assert Child 2 (now selected and focused) | ||
| expect( | ||
| find.semantics.byLabel('Child 2'), |
Contributor
There was a problem hiding this comment.
The find.semantics property does not exist on CommonFinders. To find a widget by its semantics label, use find.bySemanticsLabel instead.
find.bySemanticsLabel('Child 2'),
Contributor
Author
There was a problem hiding this comment.
find.semantics does exist.
Piinks
changed the title
segmented_control_test.dart to SemanticsHandlesegmented_control_test.dart to SemanticsHandle
justinmc
approved these changes
Jun 30, 2026
justinmc
left a comment
justinmc
left a comment
Contributor
There was a problem hiding this comment.
LGTM minus ensureSemantics 👍
|
|
||
| testWidgets('Segmented control semantics', (WidgetTester tester) async { | ||
| final semantics = SemanticsTester(tester); | ||
| final SemanticsHandle handle = tester.ensureSemantics(); |
Contributor
There was a problem hiding this comment.
ensureSemantics is not needed.
Renzo-Olivares
added
CICD
pull Bot
pushed a commit
to safarmer/flutter
that referenced
this pull request
Jul 1, 2026
…er#188863) flutter/packages@274ed3e...e742106 2026-07-01 rmolivares@renzo-olivares.dev [cupertino_ui] Re-enable `tab_scaffold_test.dart` (flutter/packages#12064) 2026-07-01 jmccandless@google.com [material_ui] Port flutter/flutter flutter#184808 "Remove semantics_tester import from card_test.dart" (flutter/packages#11965) 2026-07-01 rmolivares@renzo-olivares.dev [cupertino_ui] Migrate `sliding_segmented_control_test.dart` to `SemanticsHandle` (flutter/packages#11979) 2026-07-01 rmolivares@renzo-olivares.dev [cupertino_ui] Migrate `route_test.dart` to `SemanticsHandle` (flutter/packages#11993) 2026-07-01 rmolivares@renzo-olivares.dev [cupertino_ui] Migrate `nav_bar_test.dart` to `SemanticsHandle` (flutter/packages#11980) 2026-07-01 rmolivares@renzo-olivares.dev [cupertino_ui] Migrate `segmented_control_test.dart` to `SemanticsHandle` (flutter/packages#11982) 2026-07-01 rmolivares@renzo-olivares.dev [cupertino_ui] Re-enable `text_field_test.dart` (flutter/packages#12067) 2026-06-30 r.anantheswar@gmail.com [camera_android_camerax] Pass targetVideoEncodingBitRate to Recorder (flutter/packages#11960) 2026-06-30 1063596+reidbaker@users.noreply.github.com [camera_android_camerax] Migrate check-readiness skill from bash to Dart (flutter/packages#11943) 2026-06-30 21270878+elliette@users.noreply.github.com [material_ui] Enable `time_picker_test` (flutter/packages#12061) 2026-06-30 36861262+QuncCccccc@users.noreply.github.com [cupertino_ui] Migrate checkbox_test.dart to SemanticsHandle (flutter/packages#12065) 2026-06-30 64674824+yashas-hm@users.noreply.github.com [image_picker] Handle limit: 1 in pickMultiImage and pickMultipleMedia gracefully (flutter/packages#11825) 2026-06-30 faheemabbas766@gmail.com [cross_file] Document native mimeType behavior (flutter/packages#11662) 2026-06-30 36861262+QuncCccccc@users.noreply.github.com [material_ui] Remove `image_data.dart` imports from `circle_avatar_test.dart`, `color_scheme_test.dart` (flutter/packages#12059) 2026-06-30 36861262+QuncCccccc@users.noreply.github.com [cupertino_ui] Remove `image_data.dart` import from `scaffold_test.dart` (flutter/packages#12060) 2026-06-30 36861262+QuncCccccc@users.noreply.github.com [cupertino_ui] Remove widgets import from menu_anchor_test.dart (flutter/packages#12068) 2026-06-30 21270878+elliette@users.noreply.github.com [material_ui] Enable `checkbox_list_tile_test` (flutter/packages#12007) 2026-06-30 louisehsu@google.com [in_app_purchase_storekit] Expose quantity in Transactions (flutter/packages#11879) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#182636 and flutter/flutter#188395
This PR:
widgets/semantics_tester.dart. ReplacedSemanticsTesterwithSemanticsHandle.@Skipannotation, all tests in this file has passed.semantics_tester.darthas existed incupertino_ui, so we can directly importsemantics_tester.dart;test/folder.Pre-Review Checklist
[shared_preferences]///).