[google_maps_flutter] Add support for mapType, fullscreen, and Street View controls on web#11955
[google_maps_flutter] Add support for mapType, fullscreen, and Street View controls on web#11955puneetkukreja98 wants to merge 9 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for mapTypeControlEnabled, fullscreenControlEnabled, and streetViewControlEnabled on the web platform across the google_maps_flutter, google_maps_flutter_platform_interface, and google_maps_flutter_web packages, along with corresponding unit and integration tests. Feedback from the reviewer highlights the need to update the dependency constraints for google_maps_flutter_platform_interface in the pubspec files of both google_maps_flutter and google_maps_flutter_web to prevent potential compilation failures.
dbcf8af to
ddd2b01
Compare
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Looks good overall; please go ahead and create the first sub-PR with just the platform interface changes.
…treetViewControl options
3c1d893 to
3ef1bf7
Compare
Hi @stuartmorgan-g, I have created the first sub-PR containing just the platform interface changes here: #12191 |
…rolEnabled, fullscreenControlEnabled, and streetViewControlEnabled for web (#12191) *Part of #11955 *Part of: flutter/flutter#104111 **Context**: As suggested in the review - #11955 (review), this is a standalone sub-PR separating out just the platform interface changes. It introduces the necessary configuration flags (`mapTypeControlEnabled`, `fullscreenControlEnabled`, and `streetViewControlEnabled`) to `MapConfiguration` to pave the way for the web implementation. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
2 participants
This PR adds support for mapTypeControlEnabled, fullscreenControlEnabled, and streetViewControlEnabled on Flutter web.
Previously, these options were not exposed through the GoogleMap widget and were internally defaulted to false in MapConfiguration.
This change propagates these parameters through google_maps_flutter, google_maps_flutter_platform_interface, and google_maps_flutter_web, allowing developers to explicitly enable or disable these controls.
To preserve backward compatibility, the existing behavior is maintained by defaulting these options to false when they are not provided by the user.
I created a sample app and tested the changes using dependency_overrides. Attaching a video for reference.
google_maps_flutter_rec.mov
Fixes flutter/flutter#104111.
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2