Skip to content

[google_maps_flutter_platform_interface] Adds support for mapTypeControlEnabled, fullscreenControlEnabled, and streetViewControlEnabled for web#12191

Merged
auto-submit[bot] merged 2 commits into
flutter:mainfrom
puneetkukreja98:fix-104111-platform-interface
Jul 13, 2026
Merged

Conversation

@puneetkukreja98

@puneetkukreja98 puneetkukreja98 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Part of #11955

Part of: flutter/flutter#104111

Context:
As suggested in the review - #11955 (review), this is a standalone sub-PR separating out just the platform interface changes.
It introduces the necessary configuration flags (mapTypeControlEnabled, fullscreenControlEnabled, and streetViewControlEnabled) to MapConfiguration to pave the way for the web implementation.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

…rolEnabled, fullscreenControlEnabled, and streetViewControlEnabled for web

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for mapTypeControlEnabled, fullscreenControlEnabled, and streetViewControlEnabled properties to MapConfiguration in the google_maps_flutter_platform_interface package. The changes update the MapConfiguration class fields, constructor, diffing logic, equality operators, and hash code generation, and introduce corresponding unit tests. Since all review comments were filtered out because they focused on non-code version number changes, there is no additional feedback to provide.

Comment thread packages/google_maps_flutter/google_maps_flutter_platform_interface/CHANGELOG.md Outdated
@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

In the future, please don't use the phrase "fixes some-issue-link" in sub-PRs. GitHub will auto-close issues when PRs land that say they fix an issue, and this PR does not, by itself, fix that issue, so should not result in the issue being closed.

@github-actions github-actions Bot removed the CICD Run CI/CD label Jul 13, 2026
@puneetkukreja98

Copy link
Copy Markdown
Contributor Author

In the future, please don't use the phrase "fixes some-issue-link" in sub-PRs. GitHub will auto-close issues when PRs land that say they fix an issue, and this PR does not, by itself, fix that issue, so should not result in the issue being closed.

@stuartmorgan-g Understood, thanks for the guidance. I will avoid using the "fixes" keyword in the descriptions of sub-PRs going forward to prevent issues from auto-closing.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 13, 2026
@auto-submit
auto-submit Bot merged commit c8937ef into flutter:main Jul 13, 2026
90 checks passed
loic-sharma pushed a commit to ishaquehassan/flutter that referenced this pull request Jul 13, 2026
…er#189387)

flutter/packages@20928d5...ad2eab1

2026-07-13 35750184+motucraft@users.noreply.github.com [camera] Guard
CameraController value updates after dispose (flutter/packages#11861)
2026-07-13 dkwingsmt@users.noreply.github.com [material_ui] Remove
unused example files (flutter/packages#12179)
2026-07-13 puneetkukreja98@gmail.com
[google_maps_flutter_platform_interface] Adds support for
mapTypeControlEnabled, fullscreenControlEnabled, and
streetViewControlEnabled for web (flutter/packages#12191)
2026-07-13 44747303+theprantadutta@users.noreply.github.com [pigeon]
Report a clear error for enhanced enums (flutter/packages#11880)
2026-07-13 49699333+dependabot[bot]@users.noreply.github.com Bump
actions/labeler from 6.1.0 to 6.2.0 in the all-github-actions group
(flutter/packages#12190)
2026-07-13 stuartmorgan@google.com [shared_preferences] Convert legacy
codepath to Kotlin (flutter/packages#12139)
2026-07-12 engine-flutter-autoroll@skia.org Roll Flutter from
f7b66f3 to cf9e8af (11 revisions) (flutter/packages#12188)
2026-07-11 44525804+sailendrabathi@users.noreply.github.com
[video_player] Improve seek performance on Android
(flutter/packages#11810)
2026-07-11 stuartmorgan@google.com [pigeon] Disable iOS test
parallelization (flutter/packages#12177)
2026-07-11 dkwingsmt@users.noreply.github.com [material_ui,
cupertino_ui] Migrate snippet TODOs to `<callout-box>`
(flutter/packages#12146)
2026-07-11 dkwingsmt@users.noreply.github.com [cupertino_ui] Fix example
path (flutter/packages#12151)
2026-07-10 engine-flutter-autoroll@skia.org Roll Flutter from
dc2a870 to f7b66f3 (12 revisions) (flutter/packages#12175)
2026-07-10 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
f94f4fc to ee80f08 (3 revisions) (flutter/packages#12171)
2026-07-10 engine-flutter-autoroll@skia.org Manual roll Flutter from
91939cc to dc2a870 (50 revisions) (flutter/packages#12169)
2026-07-09 jessiewong401@gmail.com Update `legacy` test to be in Warn
Range (flutter/packages#12168)
2026-07-09 dkwingsmt@users.noreply.github.com [material_ui,
cupertino_ui] Migrate dartpad TODOs to `<callout-box>`
(flutter/packages#12120)
2026-07-09 73310711+shrabanti722@users.noreply.github.com
[video_player_avfoundation] Implement
preventsDisplaySleepDuringVideoPlayback (flutter/packages#11547)
2026-07-09 44747303+theprantadutta@users.noreply.github.com [pigeon] Add
usage docs to generated Dart event channel methods
(flutter/packages#11894)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: google_maps_flutter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants