[cupertino_ui] Migrate `radio_test.dart` to `SemanticsHandle` by Renzo-Olivares · Pull Request #11981 · flutter/packages

Renzo-Olivares · 2026-06-25T01:30:48Z

Part of flutter/flutter#182636 and flutter/flutter#188395

This PR:

Removed the cross-import of widgets/semantics_tester.dart. Replaced SemanticsTester with SemanticsHandle.
Removed @Skip annotation, all tests in this file has passed. semantics_tester.dart has existed in cupertino_ui, so we can directly import semantics_tester.dart;
Moved the file to test/ folder.

Pre-Review Checklist

gemini-code-assist

Code Review

This pull request removes the @Skip annotation from radio_test.dart, removes the import of semantics_tester.dart, and refactors the tests to use tester.ensureSemantics() and isSemantics assertions instead of SemanticsTester. The feedback suggests using addTearDown(handle.dispose) immediately after creating the SemanticsHandle to ensure it is always disposed of, and removing the manual handle.dispose() calls.

gemini-code-assist · 2026-06-25T01:31:39Z


  testWidgets('Radio selected semantics - platform adaptive', (WidgetTester tester) async {
-    final semantics = SemanticsTester(tester);
+    final SemanticsHandle handle = tester.ensureSemantics();


Using addTearDown(handle.dispose) immediately after tester.ensureSemantics() is recommended to ensure that the SemanticsHandle is always disposed of, even if the test fails or throws an exception before reaching the end of the test.

final SemanticsHandle handle = tester.ensureSemantics(); addTearDown(handle.dispose);

This is how the test was previously structured, no addTearDown was previously used. Also explanation from gemini below as to why the test fails if we do use addTearDown(handle.dispose).

From gemini:

Flutter's TestWidgetsFlutterBinding runs its end-of-test leak verifications (specifically _verifySemanticsHandlesWereDisposed) inside the test body execution flow, immediately after your test callback completes, but before returning control to the Dart test runner:

1. [Test Runner] Starts test 2. [Flutter Binding] Runs test body (your async callback) 3. Your test code executes... 4. Your test code completes. 5. [Flutter Binding] Runs _endOfTestVerifications() <-- CRITICAL POINT 6. Checking active SemanticsHandles... ERROR: "A SemanticsHandle was active at the end of the test." 7. [Test Runner] Runs addTearDown callbacks <-- TOO LATE! 8. handle.dispose() is called here.

Because the verification (Step 5) happens before the test runner runs the teardown callbacks (Step 7), the binding sees that the SemanticsHandle is still active and throws a FlutterError, failing the test.

gemini-code-assist · 2026-06-25T01:31:39Z

+      ),
+    );
+
+    handle.dispose();


Since addTearDown(handle.dispose) is used to automatically dispose of the SemanticsHandle at the end of the test, this manual call to handle.dispose() can be removed.

#11981 (comment)

gemini-code-assist · 2026-06-25T01:31:39Z


  testWidgets('Radio semantics', (WidgetTester tester) async {
-    final semantics = SemanticsTester(tester);
+    final SemanticsHandle handle = tester.ensureSemantics();


Using addTearDown(handle.dispose) immediately after tester.ensureSemantics() is recommended to ensure that the SemanticsHandle is always disposed of, even if the test fails or throws an exception before reaching the end of the test.

final SemanticsHandle handle = tester.ensureSemantics(); addTearDown(handle.dispose);

#11981 (comment)

gemini-code-assist · 2026-06-25T01:31:39Z

    );

-    semantics.dispose();
+    handle.dispose();


Since addTearDown(handle.dispose) is used to automatically dispose of the SemanticsHandle at the end of the test, this manual call to handle.dispose() can be removed.

#11981 (comment)

gemini-code-assist · 2026-06-25T01:31:39Z


  testWidgets('has semantic events', (WidgetTester tester) async {
-    final semantics = SemanticsTester(tester);
+    final SemanticsHandle handle = tester.ensureSemantics();


Using addTearDown(handle.dispose) immediately after tester.ensureSemantics() is recommended to ensure that the SemanticsHandle is always disposed of, even if the test fails or throws an exception before reaching the end of the test.

final SemanticsHandle handle = tester.ensureSemantics(); addTearDown(handle.dispose);

#11981 (comment)

gemini-code-assist · 2026-06-25T01:31:39Z

    expect(object.debugSemantics!.getSemanticsData().hasAction(SemanticsAction.tap), true);

-    semantics.dispose();
+    handle.dispose();


Since addTearDown(handle.dispose) is used to automatically dispose of the SemanticsHandle at the end of the test, this manual call to handle.dispose() can be removed.

#11981 (comment)

This reverts commit ccdef49.

Piinks

LGTM

…er#188792) flutter/packages@656ccaa...274ed3e 2026-06-30 nateshmbhat1@gmail.com [video_player_android] Add video track selection support (flutter/packages#11475) 2026-06-30 engine-flutter-autoroll@skia.org Manual roll Flutter from b081f33 to 0c80830 (1 revision) (flutter/packages#12058) 2026-06-30 36861262+QuncCccccc@users.noreply.github.com [material_ui] Remove `widgets` import from `material_test.dart` (flutter/packages#12056) 2026-06-29 36861262+QuncCccccc@users.noreply.github.com [material_ui] Remove `widgets` imports from `card_test.dart`, `checkbox_list_tile_test.dart` (flutter/packages#12054) 2026-06-29 36861262+QuncCccccc@users.noreply.github.com [material_ui] Remove `widgets/clipboard_utils.dart`, `widgets/text_selection_toolbar_utils.dart` imports from `adaptive_text_selection_toolbar_test.dart` (flutter/packages#12053) 2026-06-29 engine-flutter-autoroll@skia.org Manual roll Flutter from 11e339e to b081f33 (1 revision) (flutter/packages#12050) 2026-06-29 36861262+QuncCccccc@users.noreply.github.com [material_ui] Remove `widgets/clipboard_utils.dart` imports from `date_picker_test.dart`, `input_date_picker_form_field_test.dart`, `search_test.dart`, `selectable_text_test.dart`, `text_form_field_test.dart`, `text_selection_test.dart` (flutter/packages#12030) 2026-06-29 engine-flutter-autoroll@skia.org Manual roll Flutter from 87224e0 to 11e339e (4 revisions) (flutter/packages#12041) 2026-06-29 21270878+elliette@users.noreply.github.com [material_ui] Enable `text_field_test` (flutter/packages#12022) 2026-06-29 21270878+elliette@users.noreply.github.com [material_ui] Port PR (flutter#184807) from flutter/flutter to material_ui (flutter/packages#11972) 2026-06-29 rmolivares@renzo-olivares.dev [cupertino_ui] Migrate `button_test.dart` to `SemanticsHandle` (flutter/packages#11992) 2026-06-29 rmolivares@renzo-olivares.dev [cupertino_ui] Migrate `radio_test.dart` to `SemanticsHandle` (flutter/packages#11981) 2026-06-29 rmolivares@renzo-olivares.dev [cupertino_ui] Migrate `picker_test.dart` to `SemanticsHandle` (flutter/packages#12008) 2026-06-29 36861262+QuncCccccc@users.noreply.github.com [cupertino_ui] Create util files. Remove widgets import in `adaptive_text_selection_toolbar_test.dart` and `text_selection_test.dart` (flutter/packages#12023) 2026-06-29 21270878+elliette@users.noreply.github.com [material_ui] Enable `floating_action_button_test` (flutter/packages#12014) 2026-06-29 21270878+elliette@users.noreply.github.com [material_ui] Enable `dropdown_test` (flutter/packages#12011) 2026-06-29 21270878+elliette@users.noreply.github.com [material_ui] Enable `chip_test` (flutter/packages#12009) 2026-06-29 36861262+QuncCccccc@users.noreply.github.com [material_ui] Remove widgets import in `data_table_test.dart`, `switch_test.dart` and `tooltip_theme_test.dart` (flutter/packages#12031) 2026-06-29 burak.karahan@mail.ru [material_ui] Port flutter/flutter flutter#186670 "Use local semantics tester in Material selection tests" (flutter/packages#11983) 2026-06-29 21270878+elliette@users.noreply.github.com [material_ui] Enable `switch_list_tile_test` (flutter/packages#12020) 2026-06-29 21270878+elliette@users.noreply.github.com [material_ui] Enable `popup_menu_test` (flutter/packages#12018) 2026-06-29 21270878+elliette@users.noreply.github.com [material_ui] Enable `date_range_picker_test` (flutter/packages#12010) 2026-06-29 stuartmorgan@google.com [google_sign_in] Simplify Android user ID extraction (flutter/packages#12025) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Migrate radio_test.dart to SemanticsHandle

12b68b6

flutter-dashboard Bot added the CICD Run CI/CD label Jun 25, 2026

github-actions Bot added the triage-framework Should be looked at in framework triage label Jun 25, 2026

Renzo-Olivares changed the title ~~Migrate radio_test.dart to SemanticsHandle~~ [Decoupling] Migrate radio_test.dart to SemanticsHandle Jun 25, 2026

gemini-code-assist Bot reviewed Jun 25, 2026

View reviewed changes

updates remove unnecessary SemanticsHandle

ccdef49

github-actions Bot removed the CICD Run CI/CD label Jun 25, 2026

Renzo-Olivares mentioned this pull request Jun 25, 2026

(Test cross-imports) Don't cross-import test utils flutter/flutter#182636

Open

Renzo-Olivares added the CICD Run CI/CD label Jun 25, 2026

Renzo-Olivares mentioned this pull request Jun 25, 2026

Remove Cupertino semantics tester cross-imports flutter/flutter#186503

Closed

Piinks changed the title ~~[Decoupling] Migrate radio_test.dart to SemanticsHandle~~ [cupertino_ui] Migrate radio_test.dart to SemanticsHandle Jun 25, 2026

Piinks added the p: cupertino_ui label Jun 25, 2026

Revert "updates remove unnecessary SemanticsHandle"

d8e636f

This reverts commit ccdef49.

github-actions Bot removed the CICD Run CI/CD label Jun 25, 2026

flutter-dashboard Bot added the CICD Run CI/CD label Jun 25, 2026

Piinks approved these changes Jun 29, 2026

View reviewed changes

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 29, 2026

auto-submit Bot merged commit 9768d30 into flutter:main Jun 29, 2026
88 checks passed

engine-flutter-autoroll mentioned this pull request Jun 30, 2026

Roll Packages from 656ccaae4f49 to 274ed3e0f9f6 (23 revisions) flutter/flutter#188792

Merged

Uh oh!

Conversation

Renzo-Olivares commented Jun 25, 2026

Pre-Review Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants