[material_ui] Port flutter/flutter #186670 "Use local semantics tester in Material selection tests"

[MarlonJD]

This PR ports flutter/flutter#186670 by @MarlonJD from flutter/flutter to flutter/packages.

It moves the affected Material selection tests from material_ui's temporarily_disabled_tests directory into the main test directory now that their gross ../widgets/semantics_tester.dart import has been fixed to use material_ui's local semantics_tester.dart.

This follows the porting instructions in flutter/flutter#188444:

• merge commits from the original PR are not included
• the affected temporarily_disabled_tests files are moved into the main test directory after fixing the gross import

Validation:

• dart format --set-exit-if-changed packages/material_ui/test/checkbox_test.dart packages/material_ui/test/radio_test.dart packages/material_ui/test/range_slider_test.dart packages/material_ui/test/slider_test.dart packages/material_ui/test/toggle_buttons_test.dart
• git diff --check
• flutter test test/checkbox_test.dart test/radio_test.dart test/range_slider_test.dart test/slider_test.dart test/toggle_buttons_test.dart

The targeted test command passed with 304 tests.

[gemini-code-assist]

Code Review

This pull request removes the @Skip annotations from several test files, including checkbox_test.dart, radio_test.dart, range_slider_test.dart, slider_test.dart, and toggle_buttons_test.dart. It also updates the import path of semantics_tester.dart from a relative parent directory to a local path, and reformats several test blocks in slider_test.dart. The review feedback points out a grammatical typo in one of the test descriptions in slider_test.dart and suggests correcting 'appear' to 'appears'.

[MarlonJD]

A note on why these files moved out of temporarily_disabled_tests: flutter/flutter#188444 says that when a port fixes a gross import for tests in material_ui/cupertino_ui, those tests may be moved back into the main test directory. These five files were skipped only for the old gross ../widgets/semantics_tester.dart import. This PR fixes that to use material_ui's local semantics_tester.dart, so I moved the affected tests into packages/material_ui/test/ and removed the file-level @Skip.

I also verified the enabled tests locally with:\n\nflutter test test/checkbox_test.dart test/radio_test.dart test/range_slider_test.dart test/slider_test.dart test/toggle_buttons_test.dart

That passed with 304 tests.

[justinmc]

LGTM 👍

Thanks so much for porting this PR so quickly! Let me know if there's anything in the porting instructions in flutter/flutter#188444 that could be improved.

I see there are still a bunch of formatting changes in this PR, but I'm not sure whether or not they are needed. Let's let CI run and see if it passes, if so then I think it's good.

[flutter-dashboard]

This pull request is not mergeable in its current state, likely because of a merge conflict. Pre-submit CI jobs were not triggered. Pushing a new commit to this branch that resolves the issue will result in pre-submit jobs being scheduled.

[MarlonJD]

Thanks! I pushed ac8073ea4 to address the dashboard merge-conflict blocker. The conflict came from slider_test.dart landing on main first via #11977, so I dropped that file from this port and kept only the remaining four Material selection test moves.

GitHub now reports the PR as mergeable, and tree-status is passing. I also re-ran the local validation for the updated 4-file scope:

• git diff --check upstream/main...HEAD
• dart format --set-exit-if-changed packages/material_ui/test/checkbox_test.dart packages/material_ui/test/radio_test.dart packages/material_ui/test/range_slider_test.dart packages/material_ui/test/toggle_buttons_test.dart (0 changed)
• flutter test test/checkbox_test.dart test/radio_test.dart test/range_slider_test.dart test/toggle_buttons_test.dart (198 tests passed)

One possible improvement for the porting instructions: it may help to include a concrete PR title example, such as [material_ui] Port flutter/flutter #NNNNNN "Original PR title", and to make the temporarily_disabled_tests rule explicit: if a file was skipped only because of the gross ../widgets/semantics_tester.dart import, the port should fix the import, remove the file-level @Skip, and move the file back into packages/<package>/test/. If the equivalent file has already landed on packages/main, leave it out of the port to avoid duplicate move conflicts.

[QuncCccccc]

Hi @MarlonJD! Thanks a lot for your contribution! Could you help fix Linux analyze master and stable? Seems the imports need to be sorted.

[MarlonJD]

Fixed in 6c54de724 by sorting the material_ui selection test imports.

Local validation:

• dart format --set-exit-if-changed packages/material_ui/test/checkbox_test.dart packages/material_ui/test/radio_test.dart packages/material_ui/test/range_slider_test.dart packages/material_ui/test/toggle_buttons_test.dart (0 changed)
• dart run script/tool/bin/flutter_plugin_tools.dart analyze --packages material_ui --base-branch origin/main --custom-analysis=script/configs/custom_analysis.yaml (No issues found!)
• flutter test test/checkbox_test.dart test/radio_test.dart test/range_slider_test.dart test/toggle_buttons_test.dart (198 tests passed)

The GitHub label/check-change gates have run; waiting for the remaining Linux analyze master/stable presubmit statuses to be scheduled/reported.

[auto-submit]

autosubmit label was removed for flutter/packages/11983, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

• Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a member of flutter-hackers before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

[QuncCccccc]

LGTM