Update All Flutter Android Example Apps to 3.47 Template Versions#12195
Update All Flutter Android Example Apps to 3.47 Template Versions#12195jesswrd wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Gradle wrapper version to 9.3.1, the Android application plugin version to 9.1.0, and the Kotlin Android plugin version to 2.4.0 across multiple package examples. Feedback suggests removing redundant Gradle wrapper configurations located under the android/app/gradle/ directories of the example apps to reduce maintenance overhead.
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.0-all.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.1-all.zip |
There was a problem hiding this comment.
The Gradle wrapper configuration under android/app/gradle/wrapper/gradle-wrapper.properties is redundant and misplaced. In a standard Flutter/Android project structure, the Gradle wrapper is located at the root of the Android project (android/gradle/wrapper/gradle-wrapper.properties), which is already present and being updated in this PR. Having a duplicate wrapper under the app subproject directory is unused and increases maintenance overhead (as seen in this PR where both files have to be updated). Consider deleting the entire android/app/gradle/ directory from this and other example apps instead of updating it.
There was a problem hiding this comment.
the structure is odd but this is possibly a camera specific nuance. This does look like a duplicate directory (dupe directory; standard directory). Let me see what happens if I delete it. Tracking here.
Updated all Flutter Android plugin example apps to align with newer template versions for the Flutter 3.47 release.
Partially Addresses: flutter/flutter#189381
Related to: flutter/flutter#189380
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2