[google_fonts] Extract the config class to its own file#12202
Conversation
Extract Config from google_fonts_all_parts.dart to google_fonts_config.dart. Rename Config to GoogleFontsConfig to avoid namespace clutter. Add a deprecated Config typedef for backward compatibility. Export GoogleFontsConfig and the deprecated Config in lib/google_fonts.dart. Bump package version to 8.2.0.
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request extracts the Config class into its own file (google_fonts_config.dart) and renames it to GoogleFontsConfig. The original Config class is deprecated via a typedef pointing to GoogleFontsConfig. Additionally, the package version is bumped to 8.2.0 in pubspec.yaml and the CHANGELOG.md is updated. There are no review comments, and I have no feedback to provide.
…r#189509) flutter/packages@ad2eab1...9f95026 2026-07-15 katelovett@google.com [google_fonts] Extract the config class to its own file (flutter/packages#12202) 2026-07-14 jessiewong401@gmail.com Update All Flutter Android Example Apps to 3.47 Template Versions (flutter/packages#12195) 2026-07-14 engine-flutter-autoroll@skia.org Roll Flutter from cf9e8af to 846664b (24 revisions) (flutter/packages#12200) 2026-07-14 oss@simonbinder.eu [go_router_builder] Support analyzer 13 (flutter/packages#12189) 2026-07-14 stuartmorgan@google.com [shared_preferences] Convert legacy tests to Kotlin (flutter/packages#12193) 2026-07-13 dkwingsmt@users.noreply.github.com [material_ui, cupertino_ui] Migrate `@macro`s that are defined in Material and used in Cupertino (flutter/packages#12197) 2026-07-13 dkwingsmt@users.noreply.github.com [material_ui, cupertino_ui] Add `#region` to example files to remove license headers (flutter/packages#12170) 2026-07-13 73310711+shrabanti722@users.noreply.github.com [video_player] Implement screen auto-lock control for video playback (flutter/packages#11225) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Extract Config from google_fonts_all_parts.dart to google_fonts_config.dart. Rename Config to GoogleFontsConfig to avoid namespace clutter. Add a deprecated Config typedef for backward compatibility. Export GoogleFontsConfig and the deprecated Config in lib/google_fonts.dart. Bump package version to 8.2.0.
Unblocks #11433
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2