Conversation
dependabot
Bot
added
dependencies
dependabot
Bot
force-pushed
the
dependabot/gradle/packages/package_info_plus/package_info_plus/android/kotlin_version-1.9.10
branch
from
e318b1a to
9c9574a
Compare
Bumps `kotlin_version` from 1.7.22 to 1.9.10. Updates `org.jetbrains.kotlin:kotlin-gradle-plugin` from 1.7.22 to 1.9.10 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/v1.9.10/ChangeLog.md) - [Commits](JetBrains/kotlin@v1.7.22...v1.9.10) Updates `org.jetbrains.kotlin:kotlin-stdlib` from 1.7.22 to 1.9.10 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/v1.9.10/ChangeLog.md) - [Commits](JetBrains/kotlin@v1.7.22...v1.9.10) --- updated-dependencies: - dependency-name: org.jetbrains.kotlin:kotlin-gradle-plugin dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.jetbrains.kotlin:kotlin-stdlib dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/gradle/packages/package_info_plus/package_info_plus/android/kotlin_version-1.9.10
branch
from
9c9574a to
7ca1196
Compare
|
I had a few issues this week with updating to 1.9.x on a few projects. Had to revert to 1.8.20 in the end as there were issues with shrinking and Android builds failed. Will try it out on some project with one of Plus Plugins a bit later today. |
|
Ok great, take your time 😊 If we decide not to update, we would want to revert the already merged kotlin updates (I volunteer as I am responsible for merging). In this case, I would suggest to still keep the other parts of the three open PRs (with a lower kotlin version), as they were required to fix build issues after updating - and we'll have the same issues when we eventually update. |
Among all changes you did in this PR only bump to Java 17 was required due to Gradle's 8.x requirement to use it. If you were concerned with build failures like this: https://github.com/fluttercommunity/plus_plugins/actions/runs/6057290423/job/16438281459 it is due to what happened in Kotlin 1.8.x releases. Check out this comment from me for more details: firebase/flutterfire#11318 (comment) So I did some testing which involved creating a new Flutter project and adding different versions of Plus Plugins (with Kotlin update and without) - the issue here with Kotlin update to 1.8.x - 1.9.x is in fact that such change in plugins would require bump Kotlin version in the project which uses one of such Plus Plugins. Otherwise there are the same problems with duplicate classes error as you had yesterday on CI. What concerns me here is that requiring to bump Kotlin version is a bit different to requiring to bump Android Gradle Plugin version as we had some months ago as in case with AGP users get some build speed/memory consumption optimisations, while Kotlin version bump from 1.7.x to newer so far brings almost no benefit to Flutter projects. Based on what I described above we would either to release a breaking change and clearly state that Kotlin 1.8.x or 1.9.x is required, which might be good as due to recent changes to Gradle wrapper and Android Gradle Plugin (AGP) we also need to ask users to change Or we can stay with older Kotlin version for now, but still would have to notify users about Java 17 requirement in case of releasing new versions of plugins soon. It would be also a good option as it would not cause pain to not updated projects for now as we would wait till more of plugins/packages adopt new Kotlin version with its changes. Personally I feel that we should go with major version bump as we already have Java 17 requirement and can squeeze Kotlin version requirement here as well. |
|
@vbuberen FYI I'm driving to a retreat now and will get back to you next Monday. In any case, I would revert the changes piece by piece and check if it builds, to identify which change fixed the builds (it was not only Java)...so that we can write it in a migration guide when we update Kotlin at some point. And in case there's a release of other plus_plugins this week - the Kotlin update needs to be reverted. Have a great week ✌🏽 |
You misunderstood my previous message. Java 17 is a separate topic connected with Gradle 8.3 and AGP 8.1.1. In case with Kotlin builds failed because the example app also needs to use at least Kotlin 1.8.x. I will update PRs in the meantime.
Have a good retreat. |
…/package_info_plus/android/kotlin_version-1.9.10
vbuberen
deleted the
dependabot/gradle/packages/package_info_plus/package_info_plus/android/kotlin_version-1.9.10
branch
2 participants
Bumps
kotlin_versionfrom 1.7.22 to 1.9.10.Updates
org.jetbrains.kotlin:kotlin-gradle-pluginfrom 1.7.22 to 1.9.10Release notes
Sourced from org.jetbrains.kotlin:kotlin-gradle-plugin's releases.
... (truncated)
Changelog
Sourced from org.jetbrains.kotlin:kotlin-gradle-plugin's changelog.
... (truncated)
Commits
3db61ef[K/JS] Revert KT-60785 fix because the 1.9.0 contains old schema for function...3584af4Add ChangeLog for 1.9.107bab2dbRemove gson from compiler fat jarb925404[K/JS] Fix autoboxing for inlined function ^KT-60785 Fixed5801279[JS IR] De-optimize equality operator as workaround for KT-5750979d3dda[K/N] Update osVersionMin for arm ios and tvos simulators955598c[K/N] Pick minimal iOS/tvOS depending on the Xcode versionb1aa582[K/N] Do not check caches consistency until all of them are built0f6d84c[K/N][tests] Added a reproducer for #KT-60371d3b8607[K/N][tests] Fixed CachesAutoBuildTestUpdates
org.jetbrains.kotlin:kotlin-stdlibfrom 1.7.22 to 1.9.10Release notes
Sourced from org.jetbrains.kotlin:kotlin-stdlib's releases.
... (truncated)
Changelog
Sourced from org.jetbrains.kotlin:kotlin-stdlib's changelog.
... (truncated)
Commits
3db61ef[K/JS] Revert KT-60785 fix because the 1.9.0 contains old schema for function...3584af4Add ChangeLog for 1.9.107bab2dbRemove gson from compiler fat jarb925404[K/JS] Fix autoboxing for inlined function ^KT-60785 Fixed5801279[JS IR] De-optimize equality operator as workaround for KT-5750979d3dda[K/N] Update osVersionMin for arm ios and tvos simulators955598c[K/N] Pick minimal iOS/tvOS depending on the Xcode versionb1aa582[K/N] Do not check caches consistency until all of them are built0f6d84c[K/N][tests] Added a reproducer for #KT-60371d3b8607[K/N][tests] Fixed CachesAutoBuildTestYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)