fix(share_plus): Change Kotlin version from 1.9.10 to 1.7.22#2252
Merged
Conversation
vbuberen
added
the
share_plus
2 tasks
vbuberen
changed the title
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Kotlin update to 1.9.10 was too fast as it brought some problems, like #2134 and #2251
Due to #2134 I decided to make major release, but it was a mistake as there were more hidden problems from this Kotlin version, like requirement of Android Gradle Plugin 8.x for projects that use the plugin with this Kotlin version. And while I am a fan of using latest dependency versions in projects this is too much.
Thus, I retracted new breaking changes versions and will open a series of PRs downgrading Kotlin to release another update tomorrow.
Also, validated that downgrading Kotlin resolves the problem I reported in #2251 as that projects builds fine when
share_plusis used from this branch.Related Issues
Fixes #2251
Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).