Skip to content

[package_info_plus] fix app name on iOS and macOS#472

Merged
mhadaily merged 5 commits intofluttercommunity:mainfrom
alexbatalov:package-info-plus-apple-fix-app-name
Oct 2, 2021
Merged

[package_info_plus] fix app name on iOS and macOS#472
mhadaily merged 5 commits intofluttercommunity:mainfrom
alexbatalov:package-info-plus-apple-fix-app-name

Conversation

@alexbatalov
Copy link
Copy Markdown
Contributor

Description

This PR adds fallback to CFBundleName if CFBundleDisplayName does not exist. This approach is suggested by Apple in QA1544.

Related Issues

#432

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@mhadaily
Copy link
Copy Markdown
Member

can you merge with main and push one more time. thanks

@alexbatalov
Copy link
Copy Markdown
Contributor Author

git says it's already up to date with main

@mhadaily mhadaily added the Hacktoberfest Issues taking part in Hacktoberfest label Oct 1, 2021
@mhadaily mhadaily self-requested a review October 1, 2021 07:23
@mhadaily
Copy link
Copy Markdown
Member

mhadaily commented Oct 1, 2021

Perfect, can you please pump minor version and add this to changelog ? thanks

Copy link
Copy Markdown
Member

@mhadaily mhadaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@mhadaily mhadaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhadaily mhadaily merged commit 371f77a into fluttercommunity:main Oct 2, 2021
@alexbatalov alexbatalov deleted the package-info-plus-apple-fix-app-name branch October 13, 2021 13:36
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants