Skip to content

[package_info_plus] fix app name on iOS and macOS #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhadaily merged 5 commits into from
Oct 2, 2021
Merged

[package_info_plus] fix app name on iOS and macOS #472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
018d184
[package_info_plus] fix app name on iOS and macOS
alexbatalov Sep 28, 2021
b7f4240
fix formatting issues
alexbatalov Sep 30, 2021
9837cdb
Merge branch 'main' into package-info-plus-apple-fix-app-name
mhadaily Oct 1, 2021
a92a6d9
add changelong and pump version
mhadaily Oct 1, 2021
6d79247
add changelong and pump version
mhadaily Oct 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/package_info_plus/package_info_plus/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.2.0

- fix app name on iOS and macOS

## 1.1.0

- migrate integration_test to flutter sdk
Expand Down
2 changes: 1 addition & 1 deletion packages/package_info_plus/package_info_plus/ios/Classes/FLTPackageInfoPlusPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ - (void)handleMethodCall:(FlutterMethodCall*)call result:(FlutterResult)result {
if ([call.method isEqualToString:@"getAll"]) {
result(@{
@"appName" : [[NSBundle mainBundle] objectForInfoDictionaryKey:@"CFBundleDisplayName"]
?: [NSNull null],
?: [[NSBundle mainBundle] objectForInfoDictionaryKey:@"CFBundleName"] ?: [NSNull null],
@"packageName" : [[NSBundle mainBundle] bundleIdentifier] ?: [NSNull null],
@"version" : [[NSBundle mainBundle] objectForInfoDictionaryKey:@"CFBundleShortVersionString"]
?: [NSNull null],
Expand Down
4 changes: 2 additions & 2 deletions packages/package_info_plus/package_info_plus/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: package_info_plus
description: Flutter plugin for querying information about the application package, such as CFBundleVersion on iOS or versionCode on Android.
version: 1.1.0
version: 1.2.0
homepage: https://plus.fluttercommunity.dev/
repository: https://github.com/fluttercommunity/plus_plugins/tree/main/packages/

Expand All @@ -26,7 +26,7 @@ dependencies:
sdk: flutter
package_info_plus_platform_interface: ^1.0.2
package_info_plus_linux: ^1.0.3
package_info_plus_macos: ^1.1.1
package_info_plus_macos: ^1.2.0
package_info_plus_windows: ^1.0.3
package_info_plus_web: ^1.0.4

Expand Down
4 changes: 4 additions & 0 deletions packages/package_info_plus/package_info_plus_macos/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.2.0

- fix app name on macOS

## 1.1.1

- Improve documentation
Expand Down
2 changes: 1 addition & 1 deletion packages/package_info_plus/package_info_plus_macos/macos/Classes/FLTPackageInfoPlusPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ - (void)handleMethodCall:(FlutterMethodCall*)call result:(FlutterResult)result {
if ([call.method isEqualToString:@"getAll"]) {
result(@{
@"appName" : [[NSBundle mainBundle] objectForInfoDictionaryKey:@"CFBundleDisplayName"]
?: [NSNull null],
?: [[NSBundle mainBundle] objectForInfoDictionaryKey:@"CFBundleName"] ?: [NSNull null],
@"packageName" : [[NSBundle mainBundle] bundleIdentifier] ?: [NSNull null],
@"version" : [[NSBundle mainBundle] objectForInfoDictionaryKey:@"CFBundleShortVersionString"]
?: [NSNull null],
Expand Down
2 changes: 1 addition & 1 deletion packages/package_info_plus/package_info_plus_macos/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: package_info_plus_macos
description: macOS implementation of the package_info_plus plugin.
version: 1.1.1
version: 1.2.0
homepage: https://plus.fluttercommunity.dev/
repository: https://github.com/fluttercommunity/plus_plugins/tree/main/packages/

Expand Down