Update (android_alarm_manager_plus): Clean up plugin code, fix potential issue, improve README#517
Merged
miquelbeltran merged 4 commits intofluttercommunity:mainfrom Oct 6, 2021
Conversation
9 tasks
miquelbeltran
approved these changes
Oct 6, 2021
Member
miquelbeltran
left a comment
There was a problem hiding this comment.
LGTM, there's just a java formatting issue that needs to be fixed before merging. See more info here: https://github.com/fluttercommunity/plus_plugins/pull/517/checks?check_run_id=3808532675
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR does a clean up in plugin code mainly based on lint reported issues.

Additionally one of updated parts might fix potential issue with adding persistent alarms, since shared preferences modification was done in a wrong way (see the attached screenshot)
Finally, updated README for the plugin:
1). Removed mentions of different embedding versions, because there is no V1 used in the plugin anymore as well as the lower version of Flutter is 1.12, so there is no need to describe anything for projects with older versions.
2). Added info about
WidgetsFlutterBinding.ensureInitialized()to example of usage to address multiple reported issues.Related Issues
Readme updates close #446 and partially #276, because 276 refers to more plugins, which also need the same mention.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?