Skip to content

Update (android_alarm_manager_plus): Clean up plugin code, fix potential issue, improve README#517

Merged
miquelbeltran merged 4 commits intofluttercommunity:mainfrom
vbuberen:update/android_alarm_code
Oct 6, 2021
Merged

Update (android_alarm_manager_plus): Clean up plugin code, fix potential issue, improve README#517
miquelbeltran merged 4 commits intofluttercommunity:mainfrom
vbuberen:update/android_alarm_code

Conversation

@vbuberen
Copy link
Copy Markdown
Collaborator

@vbuberen vbuberen commented Oct 5, 2021

Description

This PR does a clean up in plugin code mainly based on lint reported issues.
Additionally one of updated parts might fix potential issue with adding persistent alarms, since shared preferences modification was done in a wrong way (see the attached screenshot)
Screenshot 2021-10-05 at 22 46 55

Finally, updated README for the plugin:
1). Removed mentions of different embedding versions, because there is no V1 used in the plugin anymore as well as the lower version of Flutter is 1.12, so there is no need to describe anything for projects with older versions.
2). Added info about WidgetsFlutterBinding.ensureInitialized() to example of usage to address multiple reported issues.

Related Issues

Readme updates close #446 and partially #276, because 276 refers to more plugins, which also need the same mention.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Copy link
Copy Markdown
Member

@miquelbeltran miquelbeltran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there's just a java formatting issue that needs to be fixed before merging. See more info here: https://github.com/fluttercommunity/plus_plugins/pull/517/checks?check_run_id=3808532675

@miquelbeltran miquelbeltran merged commit b98a172 into fluttercommunity:main Oct 6, 2021
@vbuberen vbuberen deleted the update/android_alarm_code branch October 6, 2021 10:34
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

android_alarm_manager_plus 1.2.0 Unhandled Exception

2 participants