Update (package_info_plus): Change Readme for more clarity#518
Merged
miquelbeltran merged 1 commit intofluttercommunity:mainfrom Oct 6, 2021
Merged
Update (package_info_plus): Change Readme for more clarity#518miquelbeltran merged 1 commit intofluttercommunity:mainfrom
miquelbeltran merged 1 commit intofluttercommunity:mainfrom
Conversation
Member
|
Thanks, that is necessary in all cases when the code is calling to platform channels before runApp, not only to this particular package, but I am fine to add that to this README. |
miquelbeltran
approved these changes
Oct 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a minor README update inspired by the same change in #517, but this time for another package. I believe that mentioning
WidgetsFlutterBinding.ensureInitialized()below code sample as it was before change in this PR is something that some users might miss, while proposed change ensures people will see the note on what should be done in casefromPlatform()is called beforerunApp().Related Issues
It is closed already, but still #309 is related here.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?