Skip to content

[share_plus_ios] fix sharing malformed urls#536

Merged
miquelbeltran merged 3 commits intofluttercommunity:mainfrom
alexbatalov:share-plus-ios-fix-malformed-url
Oct 13, 2021
Merged

[share_plus_ios] fix sharing malformed urls#536
miquelbeltran merged 3 commits intofluttercommunity:mainfrom
alexbatalov:share-plus-ios-fix-malformed-url

Conversation

@alexbatalov
Copy link
Copy Markdown
Contributor

Description

Fixes #531

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@miquelbeltran
Copy link
Copy Markdown
Member

Very nice, thanks! Can you add a new line on the CHANGELOG and the pubspec.yaml plugin version? as explained in the contribution guide.

@miquelbeltran miquelbeltran self-assigned this Oct 12, 2021
@miquelbeltran miquelbeltran added Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted labels Oct 12, 2021
@miquelbeltran
Copy link
Copy Markdown
Member

Can you pull the changes from main? there was a release meanwhile.

@alexbatalov
Copy link
Copy Markdown
Contributor Author

sorry for having force-pushed, have to clean up email mess in earlier commits

@miquelbeltran miquelbeltran merged commit 03df54d into fluttercommunity:main Oct 13, 2021
@miquelbeltran
Copy link
Copy Markdown
Member

thank you!

@alexbatalov alexbatalov deleted the share-plus-ios-fix-malformed-url branch October 13, 2021 13:36
miquelbeltran pushed a commit that referenced this pull request Oct 13, 2021
* [share_plus_ios] fix sharing malformed urls

* add changelog and pump version
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[share_plus] crashes on iOS when a share text starts with https://

2 participants