Skip to content

[share_plus_ios] fix sharing malformed urls #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miquelbeltran merged 3 commits into from
Oct 13, 2021
Merged

[share_plus_ios] fix sharing malformed urls #536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c16f31
[share_plus_ios] fix sharing malformed urls
alexbatalov Oct 13, 2021
b2ea360
add changelog and pump version
alexbatalov Oct 13, 2021
7aa024b
Merge branch 'main' into share-plus-ios-fix-malformed-url
alexbatalov Oct 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/share_plus/share_plus/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 3.0.4

- iOS: Fixed sharing malformed URLs

## 3.0.3

- Improve documentation for `shareFiles` method
Expand Down
7 changes: 4 additions & 3 deletions packages/share_plus/share_plus/ios/Classes/FLTSharePlusPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,9 +210,10 @@ + (void)shareText:(NSString *)shareText
subject:(NSString *)subject
withController:(UIViewController *)controller
atSource:(CGRect)origin {
NSObject *data = [shareText hasPrefix:@"https://"]
? [[NSURL alloc] initWithString:shareText]
: [[SharePlusData alloc] initWithSubject:subject text:shareText];
NSObject *data = [[NSURL alloc] initWithString:shareText];
if (data == nil) {
data = [[SharePlusData alloc] initWithSubject:subject text:shareText];
}
[self share:@[ data ] withController:controller atSource:origin];
}

Expand Down
2 changes: 1 addition & 1 deletion packages/share_plus/share_plus/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: share_plus
description: Flutter plugin for sharing content via the platform share UI, using the ACTION_SEND intent on Android and UIActivityViewController on iOS.
version: 3.0.3
version: 3.0.4
homepage: https://plus.fluttercommunity.dev/
repository: https://github.com/fluttercommunity/plus_plugins/tree/main/packages/

Expand Down