[network_info_plus_macos] remove reachability#543
Merged
miquelbeltran merged 3 commits intofluttercommunity:mainfrom Oct 13, 2021
alexbatalov:network-info-plus-remove-reachability
Merged
[network_info_plus_macos] remove reachability#543miquelbeltran merged 3 commits intofluttercommunity:mainfrom alexbatalov:network-info-plus-remove-reachability
miquelbeltran merged 3 commits intofluttercommunity:mainfrom
alexbatalov:network-info-plus-remove-reachability
Conversation
Member
|
Thanks! Can you increase the CHANGELOG and pubspec on the macos project? that will facilitate the release process on merge. edit: only increasing the version on the MacOS would be required. |
Member
|
thank you! |
Comment on lines
+1
to
+4
| ## 1.3.0 | ||
|
|
||
| - Removed `Reachability` dependency | ||
|
|
Contributor
There was a problem hiding this comment.
@alexbatalov I think you bumped the wrong package.
network_info_plus should be updated, but package_info_plus has updated.
@miquelbeltran FYI,
miquelbeltran
pushed a commit
that referenced
this pull request
Oct 13, 2021
* [network_info_plus] remove reachability * update project settings * add changelog and pump version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
Reachabilitydependency fromnetwork_info_plus_macos. It was copied fromconnectivity_plus, but it was never needed for obtaining network information.Related Issues
#542
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?