Skip to content

[network_info_plus_macos] remove reachability#543

Merged
miquelbeltran merged 3 commits intofluttercommunity:mainfrom
alexbatalov:network-info-plus-remove-reachability
Oct 13, 2021
Merged

[network_info_plus_macos] remove reachability#543
miquelbeltran merged 3 commits intofluttercommunity:mainfrom
alexbatalov:network-info-plus-remove-reachability

Conversation

@alexbatalov
Copy link
Copy Markdown
Contributor

Description

This PR removes Reachability dependency from network_info_plus_macos. It was copied from connectivity_plus, but it was never needed for obtaining network information.

Related Issues

#542

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@miquelbeltran
Copy link
Copy Markdown
Member

miquelbeltran commented Oct 12, 2021

Thanks! Can you increase the CHANGELOG and pubspec on the macos project? that will facilitate the release process on merge.

edit: only increasing the version on the MacOS would be required.

@miquelbeltran miquelbeltran self-assigned this Oct 12, 2021
@miquelbeltran miquelbeltran added Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted labels Oct 12, 2021
@miquelbeltran
Copy link
Copy Markdown
Member

thank you!

@miquelbeltran miquelbeltran merged commit b5e3052 into fluttercommunity:main Oct 13, 2021
Comment on lines +1 to +4
## 1.3.0

- Removed `Reachability` dependency

Copy link
Copy Markdown
Contributor

@kyle-seongwoo-jun kyle-seongwoo-jun Oct 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexbatalov I think you bumped the wrong package.

network_info_plus should be updated, but package_info_plus has updated.

@miquelbeltran FYI,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for noticing!

@alexbatalov alexbatalov deleted the network-info-plus-remove-reachability branch October 13, 2021 13:34
miquelbeltran pushed a commit that referenced this pull request Oct 13, 2021
* [network_info_plus] remove reachability

* update project settings

* add changelog and pump version
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants