Skip to content

[network_info_plus_macos] remove reachability #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miquelbeltran merged 3 commits into from
Oct 13, 2021
Merged

[network_info_plus_macos] remove reachability #543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c47cba
[network_info_plus] remove reachability
alexbatalov Oct 13, 2021
f29963d
update project settings
alexbatalov Oct 13, 2021
21af47a
add changelog and pump version
alexbatalov Oct 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/network_info_plus/network_info_plus/example/macos/Runner.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,12 +298,10 @@
);
inputPaths = (
"${PODS_ROOT}/Target Support Files/Pods-Runner/Pods-Runner-frameworks.sh",
"${BUILT_PRODUCTS_DIR}/Reachability/Reachability.framework",
"${BUILT_PRODUCTS_DIR}/network_info_plus_macos/network_info_plus_macos.framework",
);
name = "[CP] Embed Pods Frameworks";
outputPaths = (
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/Reachability.framework",
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/network_info_plus_macos.framework",
);
runOnlyForDeploymentPostprocessing = 0;
Expand Down
21 changes: 0 additions & 21 deletions packages/network_info_plus/network_info_plus_macos/macos/Classes/IPHelper.h
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions packages/network_info_plus/network_info_plus_macos/macos/Classes/NetworkInfoPlusPlugin.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@
import Cocoa
import CoreWLAN
import FlutterMacOS
import SystemConfiguration.CaptiveNetwork


public class NetworkInfoPlusPlugin: NSObject, FlutterPlugin {
var cwinterface: CWInterface?
Expand Down Expand Up @@ -90,4 +88,3 @@ func getWiFiAddress(family: Int32) -> String? {

return address
}

1 change: 0 additions & 1 deletion packages/network_info_plus/network_info_plus_macos/macos/network_info_plus_macos.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ Pod::Spec.new do |s|
s.source = { :http => 'https://github.com/fluttercommunity/plus_plugins/tree/main/packages/network_info_plus_macos' }
s.source_files = 'Classes/**/*'
s.dependency 'FlutterMacOS'
s.dependency 'Reachability'

s.platform = :osx
s.osx.deployment_target = '10.11'
Expand Down
4 changes: 4 additions & 0 deletions packages/package_info_plus/package_info_plus_macos/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.3.0

- Removed `Reachability` dependency

Comment on lines +1 to +4
Copy link
Copy Markdown
Contributor

@kyle-seongwoo-jun kyle-seongwoo-jun Oct 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexbatalov I think you bumped the wrong package.

network_info_plus should be updated, but package_info_plus has updated.

@miquelbeltran FYI,

Copy link
Copy Markdown
Member

@miquelbeltran miquelbeltran Oct 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for noticing!

## 1.2.0

- fix app name on macOS
Expand Down
2 changes: 1 addition & 1 deletion packages/package_info_plus/package_info_plus_macos/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: package_info_plus_macos
description: macOS implementation of the package_info_plus plugin.
version: 1.2.0
version: 1.3.0
homepage: https://plus.fluttercommunity.dev/
repository: https://github.com/fluttercommunity/plus_plugins/tree/main/packages/

Expand Down