[device_info_plus_ios] fix identifierForVendor#623
Merged
mhadaily merged 5 commits intofluttercommunity:mainfrom Jan 1, 2022
Merged
Conversation
miquelbeltran
approved these changes
Nov 30, 2021
Member
miquelbeltran
left a comment
There was a problem hiding this comment.
LGTM! Like in the other PR, could you also add a new entry on the CHANGELOG and update the version number in the pubspec? thanks!
Member
|
hey @alexbatalov some conflicts appeared, could you fix them? please ping me when ready and I will merge |
Contributor
Author
|
@miquelbeltran I've updated version and changelog, but there is other failing check, see #661, which fixes failing test in |
Member
|
thanks @alexbatalov I will finish merging and releasing once I am back in the office |
9 tasks
vbuberen
approved these changes
Dec 29, 2021
Member
|
@alexbatalov can you please resolve the conflicts then I will merge and release a new package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR likely fixes #621. Of all used
UIDeviceproperties onlyidentifierForVendoris marked as nullable. However the circumstances when it is null are hard to reproduce, so it's a guess.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?