Skip to content

[package_info_plus] fix test on linux#661

Merged
mhadaily merged 1 commit intofluttercommunity:mainfrom
alexbatalov:package-info-plus-fix-test
Dec 29, 2021
Merged

[package_info_plus] fix test on linux#661
mhadaily merged 1 commit intofluttercommunity:mainfrom
alexbatalov:package-info-plus-fix-test

Conversation

@alexbatalov
Copy link
Copy Markdown
Contributor

Description

Skips failing test on Linux which causes all recently submitted PRs to fail test_and_coverage CI step.

Flutter 2.8 started to use platform implementations while running tests (flutter/flutter#90288). Linux implementation of PackageInfoPlus does not use platform channels thus failing test.

The second issue is versioning. When #574 landed the Linux implementation version and it's dependency in main package were not updated. I don't know if that was required for publishing new code in pub, but currently published version 1.0.3 still uses old way of registering Linux plugin. Whatever Flutter 2.8 uses to find and register platform plugins, it cannot find plugins that uses that old way of registering. If you bootstrap with melos bootstrap --scope package_info_plus (this is what CI does) new way of registering in package_info_plus_linux is connected via .packages where Flutter 2.8 can find it. I don't know if it's a matter of simply publishing the package, or incrementing versions is required.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@mhadaily
Copy link
Copy Markdown
Member

@vbuberen @alexbatalov

thanks for the PR one of our CI check is failing,

└> pub publish --dry-run
       └> FAILED (in 1 packages)
           └> network_info_plus (with exit code 65

is that expected?

@alexbatalov
Copy link
Copy Markdown
Contributor Author

@mhadaily yes, it complains about missing changelog in network_info_plus which is fixed by #655. merge it first, I think the errors will go away on this one, which in turn should make #623 green as well.

@mhadaily mhadaily merged commit 341221c into fluttercommunity:main Dec 29, 2021
@alexbatalov alexbatalov deleted the package-info-plus-fix-test branch January 19, 2022 12:38
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants