[package_info_plus] fix test on linux#661
Merged
mhadaily merged 1 commit intofluttercommunity:mainfrom Dec 29, 2021
Merged
Conversation
9 tasks
vbuberen
approved these changes
Dec 27, 2021
Member
|
thanks for the PR one of our CI check is failing, is that expected? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Skips failing test on Linux which causes all recently submitted PRs to fail
test_and_coverageCI step.Flutter 2.8 started to use platform implementations while running tests (flutter/flutter#90288). Linux implementation of
PackageInfoPlusdoes not use platform channels thus failing test.The second issue is versioning. When #574 landed the Linux implementation version and it's dependency in main package were not updated. I don't know if that was required for publishing new code in
pub, but currently published version1.0.3still uses old way of registering Linux plugin. Whatever Flutter 2.8 uses to find and register platform plugins, it cannot find plugins that uses that old way of registering. If you bootstrap withmelos bootstrap --scope package_info_plus(this is what CI does) new way of registering inpackage_info_plus_linuxis connected via.packageswhere Flutter 2.8 can find it. I don't know if it's a matter of simply publishing the package, or incrementing versions is required.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?