Skip to content

Update EditorConfig for different languages#669

Merged
vbuberen merged 5 commits intofluttercommunity:mainfrom
vbuberen:update/editorconfig
Jan 3, 2022
Merged

Update EditorConfig for different languages#669
vbuberen merged 5 commits intofluttercommunity:mainfrom
vbuberen:update/editorconfig

Conversation

@vbuberen
Copy link
Copy Markdown
Collaborator

Description

While working on #666 and #667 I saw that current .editorconfig file had config applied to all files in the project, while plugins have more than just Dart file there. In this PR I modified the .editorconfig in a way to follow proper code styles for Groovy and Kotlin (https://developer.android.com/kotlin/style-guide) files as well as saved previous config for Dart files.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@vbuberen vbuberen requested a review from mhadaily January 2, 2022 09:26
Copy link
Copy Markdown
Member

@mhadaily mhadaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbuberen vbuberen merged commit 35814dc into fluttercommunity:main Jan 3, 2022
@vbuberen vbuberen deleted the update/editorconfig branch January 14, 2022 20:18
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants