Skip to content

[package_info_plus] Migrate Android part to Kotlin#670

Merged
vbuberen merged 9 commits intofluttercommunity:mainfrom
vbuberen:refactor/package_info_plus_android
Feb 20, 2022
Merged

[package_info_plus] Migrate Android part to Kotlin#670
vbuberen merged 9 commits intofluttercommunity:mainfrom
vbuberen:refactor/package_info_plus_android

Conversation

@vbuberen
Copy link
Copy Markdown
Collaborator

Description

Continue series of PRs on migrating Plus plugins Android parts to Kotlin.
This PR is based a branch which is based on #669 to have proper formatting for different languages.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@nohli
Copy link
Copy Markdown
Member

nohli commented Jan 4, 2022

Is it possible to add tests for the native part?

@vbuberen
Copy link
Copy Markdown
Collaborator Author

vbuberen commented Jan 8, 2022

Is it possible to add tests for the native part?

Yes, it is possible. It is something I want to do in the following PRs, since target these Migration ones to be just a switch of language without additional changes.

@vbuberen vbuberen requested a review from miquelbeltran January 8, 2022 18:48
@vbuberen vbuberen added android package_info_plus stuff related to package_info_plus labels Jan 15, 2022
Copy link
Copy Markdown
Member

@miquelbeltran miquelbeltran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vbuberen vbuberen merged commit d58f574 into fluttercommunity:main Feb 20, 2022
@vbuberen vbuberen deleted the refactor/package_info_plus_android branch February 20, 2022 14:36
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

android package_info_plus stuff related to package_info_plus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants