Skip to content
This repository was archived by the owner on Oct 9, 2023. It is now read-only.

Remove single task execution default timeout #564

Merged
hamersaw merged 2 commits into from
May 17, 2023
Merged

Remove single task execution default timeout #564

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a920d4
removed default timeout
hamersaw May 16, 2023
fe87247
removed unnecessary dependencies
hamersaw May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions pkg/manager/impl/util/single_task_execution.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import (
"context"
"fmt"
"strings"
"time"
"unicode"

"github.com/flyteorg/flyteadmin/pkg/errors"
Expand All @@ -17,7 +16,6 @@ import (
"github.com/flyteorg/flyteidl/gen/pb-go/flyteidl/admin"
"github.com/flyteorg/flyteidl/gen/pb-go/flyteidl/core"
"github.com/flyteorg/flytestdlib/logger"
"github.com/golang/protobuf/ptypes"
"google.golang.org/grpc/codes"
)

Expand All @@ -26,7 +24,6 @@ const maxNodeIDLength = 63
var defaultRetryStrategy = core.RetryStrategy{
Retries: 3,
}
var defaultTimeout = ptypes.DurationProto(24 * time.Hour)

const systemNamePrefix = ".flytegen.%s"

Expand Down Expand Up @@ -102,7 +99,6 @@ func CreateOrGetWorkflowModel(
Metadata: &core.NodeMetadata{
Name: generateNodeNameFromTask(taskIdentifier.Name),
Retries: &defaultRetryStrategy,
Timeout: defaultTimeout,
},
Inputs: generateBindings(*task.Closure.CompiledTask.Template.Interface.Inputs, noInputNodeID),
Target: &core.Node_TaskNode{
Expand Down