This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Remove single task execution default timeout#564
Merged
Conversation
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
hamersaw
requested review from
EngHabu,
eapolinario,
katrogan,
kumare3,
pmahindrakar-oss and
wild-endeavor
as code owners
Codecov Report
@@ Coverage Diff @@
## master #564 +/- ##
==========================================
+ Coverage 58.45% 59.99% +1.54%
==========================================
Files 168 168
Lines 16122 13194 -2928
==========================================
- Hits 9424 7916 -1508
+ Misses 5859 4439 -1420
Partials 839 839
Flags with carried forward coverage won't be shown. Click here to find out more.
|
eapolinario
approved these changes
May 16, 2023
wild-endeavor
added a commit
to flyteorg/flyte
that referenced
this pull request
May 22, 2023
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> ### Admin - v1.1.100 * Inject user identifier to ExecutionSpec by @ByronHsu in flyteorg/flyteadmin#549 * Fix flaky test by @eapolinario in flyteorg/flyteadmin#563 * Add oauth http proxy for external server & Extract email from azure claim by @ByronHsu in flyteorg/flyteadmin#553 * Remove single task execution default timeout by @hamersaw in flyteorg/flyteadmin#564 * Revert conditional setting of SecurityContext when launching security context by @wild-endeavor in flyteorg/flyteadmin#566 ### Console - v1.8.2 * Export Flytedecks support for TLRO by @james-union in flyteorg/flyteconsole#757 * fix: filter executions by version and name by @ursucarina in flyteorg/flyteconsole#758 * fix: task recent runs should filter by version by @ursucarina in flyteorg/flyteconsole#759 * Bug: Execution Page's back button returns Workflows route from Launch Plan route #patch by @FrankFlitton in flyteorg/flyteconsole#760 * chore: add item when mapped task by @jsonporter in flyteorg/flyteconsole#761 * Feature: Fullview Flyte Deck modal by @FrankFlitton in flyteorg/flyteconsole#764 ### Propeller - v1.1.90 * Add grpc plugin to loader.go by @pingsutw in flyteorg/flytepropeller#562
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* removed default timeout Signed-off-by: Daniel Rammer <daniel@union.ai> * removed unnecessary dependencies Signed-off-by: Daniel Rammer <daniel@union.ai> --------- Signed-off-by: Daniel Rammer <daniel@union.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Currently single task execution imposes a
24hdefault deadline on the node when constructing a default workflow. We recently set the default workflow and node deadlines to0sbecause users unexpectedly saw executions terminated based on deadlines. We should address this similarly.Type
Are all requirements met?
Complete description
^^^
Tracking Issue
flyteorg/flyte#3642
Follow-up issue
NA