fix: task recent runs should filter by version#759
Merged
Conversation
Signed-off-by: Carina Ursu <carina@union.ai>
ursucarina
requested review from
a team,
cloud-shannon,
james-union and
jsonporter
and removed request for
a team
Signed-off-by: Carina Ursu <carina@union.ai>
Codecov Report
@@ Coverage Diff @@
## master #759 +/- ##
==========================================
- Coverage 65.90% 65.90% -0.01%
==========================================
Files 489 489
Lines 11915 11917 +2
Branches 2196 2198 +2
==========================================
+ Hits 7853 7854 +1
- Misses 4062 4063 +1
|
| operation: FilterOperationName.EQ, | ||
| value: name, | ||
| }, | ||
| ...(version |
Member
There was a problem hiding this comment.
[nit] we can actually also use && to make it more concise
...(version && [...])
Contributor
Author
There was a problem hiding this comment.
i did it that way because there's a difference between
[1,2, ...[]] and [1,2,...undefined]
cloud-shannon
approved these changes
May 17, 2023
Member
cloud-shannon
left a comment
cloud-shannon
left a comment
There was a problem hiding this comment.
minor nit but otherwise lgtm
Collaborator
|
🎉 This PR is included in version 1.8.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
wild-endeavor
added a commit
to flyteorg/flyte
that referenced
this pull request
May 22, 2023
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> ### Admin - v1.1.100 * Inject user identifier to ExecutionSpec by @ByronHsu in flyteorg/flyteadmin#549 * Fix flaky test by @eapolinario in flyteorg/flyteadmin#563 * Add oauth http proxy for external server & Extract email from azure claim by @ByronHsu in flyteorg/flyteadmin#553 * Remove single task execution default timeout by @hamersaw in flyteorg/flyteadmin#564 * Revert conditional setting of SecurityContext when launching security context by @wild-endeavor in flyteorg/flyteadmin#566 ### Console - v1.8.2 * Export Flytedecks support for TLRO by @james-union in flyteorg/flyteconsole#757 * fix: filter executions by version and name by @ursucarina in flyteorg/flyteconsole#758 * fix: task recent runs should filter by version by @ursucarina in flyteorg/flyteconsole#759 * Bug: Execution Page's back button returns Workflows route from Launch Plan route #patch by @FrankFlitton in flyteorg/flyteconsole#760 * chore: add item when mapped task by @jsonporter in flyteorg/flyteconsole#761 * Feature: Fullview Flyte Deck modal by @FrankFlitton in flyteorg/flyteconsole#764 ### Propeller - v1.1.90 * Add grpc plugin to loader.go by @pingsutw in flyteorg/flytepropeller#562
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
filters tasks by version
Type
Are all requirements met?
Complete description
filters tasks by version
test on:
wf1
wf2
task 1
task 2
task 3
launch plan
Tracking Issue
fixes flyteorg/flyte#3538
Follow-up issue
NA